You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/10/11 09:48:40 UTC

[GitHub] dhlaluku commented on a change in pull request #2839: Enable DPDK support on KVM

dhlaluku commented on a change in pull request #2839: Enable DPDK support on KVM
URL: https://github.com/apache/cloudstack/pull/2839#discussion_r224384777
 
 

 ##########
 File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
 ##########
 @@ -514,6 +515,8 @@
     private static final ConfigKey<Boolean> AllowDeployVmIfGivenHostFails = new ConfigKey<Boolean>("Advanced", Boolean.class, "allow.deploy.vm.if.deploy.on.given.host.fails", "false",
             "allow vm to deploy on different host if vm fails to deploy on the given host ", true);
 
+    private static final ConfigKey<Boolean> EnableAdditionalVmConfig = new ConfigKey<>("Advanced", Boolean.class, "enable.additional.vm.configuration",
 
 Review comment:
   Can we change this setting from 'enable.additional.vm.configuration' to 'additional.vm.configuration.allow' or 'additional.vm.configuration.enable'?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services