You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/03 10:25:54 UTC

[GitHub] [pulsar] liangyepianzhou commented on a change in pull request #12449: [Transaction] Offload transaction data

liangyepianzhou commented on a change in pull request #12449:
URL: https://github.com/apache/pulsar/pull/12449#discussion_r741796368



##########
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -1848,8 +1851,10 @@ public void asyncReadEntry(PositionImpl position, ReadEntryCallback callback, Ob
     }
 
     private void internalReadFromLedger(ReadHandle ledger, OpReadEntry opReadEntry) {
-
-        if (opReadEntry.readPosition.compareTo(opReadEntry.maxPosition) > 0) {
+        //entries that has been offloaded do not need to be restricted by TransactionBuffer`maxReadPosition
+        LedgerInfo info = ledgers.get(ledger.getId());
+        if (opReadEntry.readPosition.compareTo(opReadEntry.maxPosition) > 0

Review comment:
       We don’t know if the messages after MaxReadPosition are aborted.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org