Re: svn commit: r1457734 - in /lucene/dev/trunk: ./ dev-tools/eclipse/dot.settings/ dev-tools/maven/ dev-tools/scripts/ lucene/ lucene/core/src/java/org/apache/lucene/util/ lucene/tools/javadoc/ lucene/tools/javadoc/java6/ lucene/tools/javadoc/java7/ solr/...

[Robert Muir <rc...@gmail.com>]

On Mon, Mar 18, 2013 at 8:28 AM,  <us...@apache.org> wrote:
> Modified: lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/XMLResponseParser.java
> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/XMLResponseParser.java?rev=1457734&r1=1457733&r2=1457734&view=diff
> ==============================================================================
> --- lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/XMLResponseParser.java (original)
> +++ lucene/dev/trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/XMLResponseParser.java Mon Mar 18 12:28:52 2013
> @@ -55,6 +55,7 @@ public class XMLResponseParser extends R
>    static {
>      factory = XMLInputFactory.newInstance();
>      try {
> +      // nocommit: still true for 1.7?
>        // The java 1.6 bundled stax parser (sjsxp) does not currently have a thread-safe
>        // XMLInputFactory, as that implementation tries to cache and reuse the
>        // XMLStreamReader.  Setting the parser-specific "reuse-instance" property to false
>

Thanks for taking the issue Uwe. There were still some nocommits in
the patch, for xml-policeman review:

* solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/XPathRecordReader.java
* solr/core/src/java/org/apache/solr/handler/DocumentAnalysisRequestHandler.java
* solr/core/src/java/org/apache/solr/handler/loader/XMLLoader.java
* solr/solrj/src/java/org/apache/solr/client/solrj/impl/XMLResponseParser.java

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org