You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/06/23 09:05:59 UTC

Review Request 35768: Consistent 'Test' suffix in stout test names.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35768/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Till Toenshoff.


Repository: mesos


Description
-------

Follow-up from [r35697](https://reviews.apache.org/r/35697/).


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/tests/base64_tests.cpp 28a94f998db6719af49aafb82e0fa84c4411ed81 
  3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp dc052845c59f7c3a57e938efadafda93f41f58fa 
  3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp 3065278ae94bc4c3d754133d88c4da9d6e195fcb 
  3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp cdedacde1247e766e240ea1c2d86573c6ecccafd 
  3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp 1e5f4494204c8901552afcb7e61fd503651949dc 
  3rdparty/libprocess/3rdparty/stout/tests/svn_tests.cpp d5e0f6efd6f6c92abbafa70e041064db2ae58cac 
  3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp b37d7f4e99da8fd3211397ebbb75f070229f9f81 

Diff: https://reviews.apache.org/r/35768/diff/


Testing
-------

`make check`


Thanks,

Michael Park

Re: Review Request 35768: Consistent 'Test' suffix in stout test names.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35768/#review88938
-----------------------------------------------------------


Patch looks great!

Reviews applied: [35768]

All tests passed.

- Mesos ReviewBot


On June 23, 2015, 7:05 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35768/
> -----------------------------------------------------------
> 
> (Updated June 23, 2015, 7:05 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Follow-up from [r35697](https://reviews.apache.org/r/35697/).
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/tests/base64_tests.cpp 28a94f998db6719af49aafb82e0fa84c4411ed81 
>   3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp dc052845c59f7c3a57e938efadafda93f41f58fa 
>   3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp 3065278ae94bc4c3d754133d88c4da9d6e195fcb 
>   3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp cdedacde1247e766e240ea1c2d86573c6ecccafd 
>   3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp 1e5f4494204c8901552afcb7e61fd503651949dc 
>   3rdparty/libprocess/3rdparty/stout/tests/svn_tests.cpp d5e0f6efd6f6c92abbafa70e041064db2ae58cac 
>   3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp b37d7f4e99da8fd3211397ebbb75f070229f9f81 
> 
> Diff: https://reviews.apache.org/r/35768/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 35768: Consistent 'Test' suffix in stout test names.

Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35768/#review89089
-----------------------------------------------------------

Ship it!


Ship It!

- Isabel Jimenez


On June 23, 2015, 7:05 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35768/
> -----------------------------------------------------------
> 
> (Updated June 23, 2015, 7:05 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Follow-up from [r35697](https://reviews.apache.org/r/35697/).
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/tests/base64_tests.cpp 28a94f998db6719af49aafb82e0fa84c4411ed81 
>   3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp dc052845c59f7c3a57e938efadafda93f41f58fa 
>   3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp 3065278ae94bc4c3d754133d88c4da9d6e195fcb 
>   3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp cdedacde1247e766e240ea1c2d86573c6ecccafd 
>   3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp 1e5f4494204c8901552afcb7e61fd503651949dc 
>   3rdparty/libprocess/3rdparty/stout/tests/svn_tests.cpp d5e0f6efd6f6c92abbafa70e041064db2ae58cac 
>   3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp b37d7f4e99da8fd3211397ebbb75f070229f9f81 
> 
> Diff: https://reviews.apache.org/r/35768/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 35768: Consistent 'Test' suffix in stout test names.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35768/#review90539
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On June 23, 2015, 7:05 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35768/
> -----------------------------------------------------------
> 
> (Updated June 23, 2015, 7:05 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Follow-up from [r35697](https://reviews.apache.org/r/35697/).
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/tests/base64_tests.cpp 28a94f998db6719af49aafb82e0fa84c4411ed81 
>   3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp dc052845c59f7c3a57e938efadafda93f41f58fa 
>   3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp 3065278ae94bc4c3d754133d88c4da9d6e195fcb 
>   3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp cdedacde1247e766e240ea1c2d86573c6ecccafd 
>   3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp 1e5f4494204c8901552afcb7e61fd503651949dc 
>   3rdparty/libprocess/3rdparty/stout/tests/svn_tests.cpp d5e0f6efd6f6c92abbafa70e041064db2ae58cac 
>   3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp b37d7f4e99da8fd3211397ebbb75f070229f9f81 
> 
> Diff: https://reviews.apache.org/r/35768/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>