You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/05/22 08:06:09 UTC
[GitHub] [incubator-mxnet] larroy commented on a change in pull request
#14879: Add cpu implementation for Deformable Convolution
larroy commented on a change in pull request #14879: Add cpu implementation for Deformable Convolution
URL: https://github.com/apache/incubator-mxnet/pull/14879#discussion_r283582913
##########
File path: src/operator/contrib/nn/deformable_im2col.cuh
##########
@@ -282,24 +288,33 @@ __global__ void deformable_im2col_gpu_kernel(const int n, const DType* data_im,
*/
template <typename DType>
inline void deformable_im2col(mshadow::Stream<gpu>* s,
- const DType* data_im, const DType* data_offset,
- const mxnet::TShape& im_shape, const mxnet::TShape& col_shape, const mxnet::TShape& kernel_shape,
- const mxnet::TShape& pad, const mxnet::TShape& stride, const mxnet::TShape& dilation,
- const uint32_t deformable_group, DType* data_col) {
+ const DType* data_im,
+ const DType* data_offset,
+ const mxnet::TShape& im_shape,
+ const mxnet::TShape& col_shape,
+ const mxnet::TShape& kernel_shape,
+ const mxnet::TShape& pad,
+ const mxnet::TShape& stride,
+ const mxnet::TShape& dilation,
+ const uint32_t deformable_group,
+ DType* data_col) {
// num_axes should be smaller than block size
- index_t num_spatial_axes = kernel_shape.ndim();
+ int num_spatial_axes = kernel_shape.ndim();
Review comment:
can be const?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services