You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/25 07:33:25 UTC
[GitHub] [arrow-datafusion] msathis commented on pull request #387: Constant fold / optimize `to_timestamp` function during planning
msathis commented on pull request #387:
URL: https://github.com/apache/arrow-datafusion/pull/387#issuecomment-847623401
> Oh no -- we have some clippy errors
>
> https://github.com/apache/arrow-datafusion/pull/387/checks?check_run_id=2658215529
>
> ```
>
> error: useless use of `format!`
> --> datafusion/src/optimizer/constant_folding.rs:680:24
> |
> 680 | let expected = format!(
> | ________________________^
> 681 | | "Projection: TimestampNanosecond(1599566400000000000)\
> 682 | | \n TableScan: test projection=None",
> 683 | | );
> | |_________^
> |
> = note: `-D clippy::useless-format` implied by `-D warnings`
> = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
> help: consider using `.to_string()`
> |
> 680 | let expected = "Projection: TimestampNanosecond(1599566400000000000)\
> 681 | \n TableScan: test projection=None".to_string();
> |
>
> error: useless use of `format!`
> --> datafusion/src/optimizer/constant_folding.rs:703:24
> |
> 703 | let expected = format!(
> | ________________________^
> 704 | | "Projection: totimestamp(Utf8(\"I\'M NOT A TIMESTAMP\"))\
> 705 | | \n TableScan: test projection=None",
> 706 | | );
> | |_________^
> |
> = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
> help: consider using `.to_string()`
> ```
For some strange reason `cargo clippy` on my local doesn't throw these errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org