[jira] [Commented] (YUNIKORN-2734) make configurable for pods in k8shim pkg/client/kubeclient.go

["Wilfred Spiegelenburg (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YUNIKORN-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864611#comment-17864611 ] 

Wilfred Spiegelenburg commented on YUNIKORN-2734:
-------------------------------------------------

This should only used for placeholders. YuniKorn should not delete any other pods.

Therefor It should not be configurable. The TODO should not be there.

> make configurable for pods in k8shim pkg/client/kubeclient.go
> -------------------------------------------------------------
>
>                 Key: YUNIKORN-2734
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2734
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>            Reporter: Huang Guan Hao
>            Priority: Minor
>
> for remove //TODO comment
> in pkg/client/kubeclient.go
> https://github.com/rich7420/yunikorn-k8shim/blob/a5e875086fc8fd7e2bf4cdddf532d768d7a5f54c/pkg/client/kubeclient.go#L141
> Make the grace period for pod deletion configurable.
> Currently, the grace period for deleting pods is hardcoded to 3 seconds.
> This might not be suitable for all use cases, as some pods might require more time to gracefully shut down. In the future, this value should be made configurable, either through a function parameter, configuration file, or environment variable, to provide more flexibility and accommodate different scenarios.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org