You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/16 09:18:29 UTC

[GitHub] [incubator-doris] xlwh opened a new pull request, #9060: [enhancement]Format and fix some code style for exec

xlwh opened a new pull request, #9060:
URL: https://github.com/apache/incubator-doris/pull/9060

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   Describe the overview of changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: No
   2. Has unit tests been added: No Need
   3. Has document been added or modified: No Need
   4. Does it need to update dependencies: No
   5. Are there any changes that cannot be rolled back: Yes
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] jackwener commented on pull request #9060: [enhancement]Format and fix some code style for exec

Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #9060:
URL: https://github.com/apache/incubator-doris/pull/9060#issuecomment-1109859218

   Thanks for your contribution❤
   But Format `BE` will be finished  at once in the future like #9083 . So it's pity this PR is redundant.
   
   If you are interested in the relevant part. 
   You can see the `FE` format part.
   
   I split some subtask in this issue #8985 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] morningman commented on pull request #9060: [enhancement]Format and fix some code style for exec

Posted by GitBox <gi...@apache.org>.
morningman commented on PR #9060:
URL: https://github.com/apache/incubator-doris/pull/9060#issuecomment-1110495822

   We will do this later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] jackwener commented on a diff in pull request #9060: [enhancement]Format and fix some code style for exec

Posted by GitBox <gi...@apache.org>.
jackwener commented on code in PR #9060:
URL: https://github.com/apache/incubator-doris/pull/9060#discussion_r852558907


##########
be/src/exec/text_converter.hpp:
##########
@@ -297,6 +299,4 @@ inline bool TextConverter::write_column(const SlotDescriptor* slot_desc,
     return true;
 }
 
-} // namespace doris
-
-#endif
\ No newline at end of file
+} // namespace doris

Review Comment:
   newline



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] morningman closed pull request #9060: [enhancement]Format and fix some code style for exec

Posted by GitBox <gi...@apache.org>.
morningman closed pull request #9060: [enhancement]Format and fix some code style for exec
URL: https://github.com/apache/incubator-doris/pull/9060


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org