You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Dmitry Batkovich <ba...@gmail.com> on 2014/04/21 22:26:14 UTC
Re: Review Request 17586: AWSAPI: cloudstack api on POST requests (instead
GET), ssl enabling fixed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17586/
-----------------------------------------------------------
(Updated April 21, 2014, 8:26 p.m.)
Review request for cloudstack and Sebastien Goasguen.
Changes
-------
yet another attempt. I have some problems to update review board diff and additionally have attached to file attachments
Repository: cloudstack-git
Description
-------
* CloudStackClient.java http request mechanism replaced from GET requests to POST for supporting EC2 requests larger than 2KB
* SSL enabling fixed in EC2Engine.java
Diffs (updated)
-----
awsapi/conf/ec2-service.properties.in 82f5ad8
awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java cd20214
awsapi/src/com/cloud/bridge/util/JsonAccessor.java 2a94dea
awsapi/src/com/cloud/bridge/util/JsonElementUtil.java PRE-CREATION
awsapi/src/com/cloud/bridge/util/JsonElementUtil.java 2d8afb5
awsapi/src/com/cloud/stack/CloudStackApi.java b7a1210
awsapi/src/com/cloud/stack/CloudStackClient.java 03eba96
awsapi/src/com/cloud/stack/CloudStackClientException.java PRE-CREATION
awsapi/src/com/cloud/stack/CloudStackClientException.java ac1b3ef
awsapi/src/com/cloud/stack/CloudStackCommand.java 8d6aa68
awsapi/src/com/cloud/stack/CloudStackQueryBuilder.java PRE-CREATION
awsapi/test/com/cloud/gate/util/CloudStackClientTestCase.java 826cb3a
awsapi/test/com/cloud/gate/util/JsonAccessorTestCase.java 8603e59
awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java PRE-CREATION
Diff: https://reviews.apache.org/r/17586/diff/
Testing
-------
File Attachments (updated)
----------------
cloudstack_api_post_and_ssl_fix.patch
https://reviews.apache.org/media/uploaded/files/2014/04/21/93dfe17d-2f7f-4413-80ba-76d33a3b5a47__cloudstack_api_post_and_ssl_fix.patch
Thanks,
Dmitry Batkovich
Re: Review Request 17586: AWSAPI: cloudstack api on POST requests
(instead GET), ssl enabling fixed
Posted by Daan Hoogland <da...@gmail.com>.
Dmitri,
Can you maybe start a new review request with a git format-patch result in
it? https://reviews.apache.org/r/17586/ is a mess and the last version of
the diff is not a mail format but a regular diff and I do want to
glorifyingly add your name to the commit;) It doesn't apply cleanly either.
What part does apply seems to build so I don't think I'll have a problem
with any clean replacement you send.
sorry for the hassle,
Daan
On Sun, May 11, 2014 at 10:40 PM, Dmitry Batkovich <ba...@gmail.com>wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17586/
>
> On April 23rd, 2014, 12:41 p.m. UTC, *daan Hoogland* wrote:
>
> awsapi/src/com/cloud/bridge/util/JsonElementUtil.java: seems to be there twice as well!?!
>
> On April 23rd, 2014, 5:25 p.m. UTC, *Dmitry Batkovich* wrote:
>
> I have written about it that "Update diff" works strange for me and I have attached patch to "File Attachments". In raw file I see only one JsonElementUtil and other classes...also it's good with licence headers
>
> On April 23rd, 2014, 5:26 p.m. UTC, *Dmitry Batkovich* wrote:
>
> and now I have fixed code styles problems. patch in attachements
>
> Daan, can you see this attachment? We are grateful if this patch will be applied as soon as possible.
>
>
> - Dmitry
>
> On April 22nd, 2014, 10:50 p.m. UTC, Dmitry Batkovich wrote:
> Review request for cloudstack, daan Hoogland and Sebastien Goasguen.
> By Dmitry Batkovich.
>
> *Updated April 22, 2014, 10:50 p.m.*
> *Repository: * cloudstack-git
> Description
>
> * CloudStackClient.java http request mechanism replaced from GET requests to POST for supporting EC2 requests larger than 2KB
> * SSL enabling fixed in EC2Engine.java
>
> Diffs
>
> - awsapi/conf/ec2-service.properties.in (82f5ad8)
> - awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java (cd20214)
> - awsapi/src/com/cloud/bridge/util/JsonAccessor.java (2a94dea)
> - awsapi/src/com/cloud/bridge/util/JsonElementUtil.java (PRE-CREATION)
> - awsapi/src/com/cloud/bridge/util/JsonElementUtil.java (2d8afb5)
> - awsapi/src/com/cloud/stack/CloudStackApi.java (b7a1210)
> - awsapi/src/com/cloud/stack/CloudStackClient.java (03eba96)
> - awsapi/src/com/cloud/stack/CloudStackClientException.java
> (PRE-CREATION)
> - awsapi/src/com/cloud/stack/CloudStackClientException.java (ac1b3ef)
> - awsapi/src/com/cloud/stack/CloudStackCommand.java (8d6aa68)
> - awsapi/src/com/cloud/stack/CloudStackQueryBuilder.java (PRE-CREATION)
> - awsapi/test/com/cloud/gate/util/CloudStackClientTestCase.java
> (826cb3a)
> - awsapi/test/com/cloud/gate/util/JsonAccessorTestCase.java (8603e59)
> - awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java
> (PRE-CREATION)
>
> View Diff <https://reviews.apache.org/r/17586/diff/>
> File Attachments
>
> - cloudstack_api_post_and_ssl_fix.patch<https://reviews.apache.org/media/uploaded/files/2014/04/21/93dfe17d-2f7f-4413-80ba-76d33a3b5a47__cloudstack_api_post_and_ssl_fix.patch>
>
>
--
Daan
Re: Review Request 17586: AWSAPI: cloudstack api on POST requests (instead
GET), ssl enabling fixed
Posted by Dmitry Batkovich <ba...@gmail.com>.
> On April 23, 2014, 12:41 p.m., daan Hoogland wrote:
> > awsapi/src/com/cloud/bridge/util/JsonElementUtil.java: seems to be there twice as well!?!
>
> Dmitry Batkovich wrote:
> I have written about it that "Update diff" works strange for me and I have attached patch to "File Attachments". In raw file I see only one JsonElementUtil and other classes...also it's good with licence headers
>
> Dmitry Batkovich wrote:
> and now I have fixed code styles problems. patch in attachements
Daan, can you see this attachment? We are grateful if this patch will be applied as soon as possible.
- Dmitry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17586/#review41138
-----------------------------------------------------------
On April 22, 2014, 10:50 p.m., Dmitry Batkovich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17586/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 10:50 p.m.)
>
>
> Review request for cloudstack, daan Hoogland and Sebastien Goasguen.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> * CloudStackClient.java http request mechanism replaced from GET requests to POST for supporting EC2 requests larger than 2KB
> * SSL enabling fixed in EC2Engine.java
>
>
> Diffs
> -----
>
> awsapi/conf/ec2-service.properties.in 82f5ad8
> awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java cd20214
> awsapi/src/com/cloud/bridge/util/JsonAccessor.java 2a94dea
> awsapi/src/com/cloud/bridge/util/JsonElementUtil.java PRE-CREATION
> awsapi/src/com/cloud/bridge/util/JsonElementUtil.java 2d8afb5
> awsapi/src/com/cloud/stack/CloudStackApi.java b7a1210
> awsapi/src/com/cloud/stack/CloudStackClient.java 03eba96
> awsapi/src/com/cloud/stack/CloudStackClientException.java PRE-CREATION
> awsapi/src/com/cloud/stack/CloudStackClientException.java ac1b3ef
> awsapi/src/com/cloud/stack/CloudStackCommand.java 8d6aa68
> awsapi/src/com/cloud/stack/CloudStackQueryBuilder.java PRE-CREATION
> awsapi/test/com/cloud/gate/util/CloudStackClientTestCase.java 826cb3a
> awsapi/test/com/cloud/gate/util/JsonAccessorTestCase.java 8603e59
> awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17586/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> cloudstack_api_post_and_ssl_fix.patch
> https://reviews.apache.org/media/uploaded/files/2014/04/21/93dfe17d-2f7f-4413-80ba-76d33a3b5a47__cloudstack_api_post_and_ssl_fix.patch
>
>
> Thanks,
>
> Dmitry Batkovich
>
>
Re: Review Request 17586: AWSAPI: cloudstack api on POST requests (instead
GET), ssl enabling fixed
Posted by Dmitry Batkovich <ba...@gmail.com>.
> On April 23, 2014, 12:41 p.m., daan Hoogland wrote:
> > awsapi/src/com/cloud/bridge/util/JsonElementUtil.java: seems to be there twice as well!?!
I have written about it that "Update diff" works strange for me and I have attached patch to "File Attachments". In raw file I see only one JsonElementUtil and other classes...also it's good with licence headers
- Dmitry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17586/#review41138
-----------------------------------------------------------
On April 22, 2014, 10:50 p.m., Dmitry Batkovich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17586/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 10:50 p.m.)
>
>
> Review request for cloudstack, daan Hoogland and Sebastien Goasguen.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> * CloudStackClient.java http request mechanism replaced from GET requests to POST for supporting EC2 requests larger than 2KB
> * SSL enabling fixed in EC2Engine.java
>
>
> Diffs
> -----
>
> awsapi/conf/ec2-service.properties.in 82f5ad8
> awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java cd20214
> awsapi/src/com/cloud/bridge/util/JsonAccessor.java 2a94dea
> awsapi/src/com/cloud/bridge/util/JsonElementUtil.java PRE-CREATION
> awsapi/src/com/cloud/bridge/util/JsonElementUtil.java 2d8afb5
> awsapi/src/com/cloud/stack/CloudStackApi.java b7a1210
> awsapi/src/com/cloud/stack/CloudStackClient.java 03eba96
> awsapi/src/com/cloud/stack/CloudStackClientException.java PRE-CREATION
> awsapi/src/com/cloud/stack/CloudStackClientException.java ac1b3ef
> awsapi/src/com/cloud/stack/CloudStackCommand.java 8d6aa68
> awsapi/src/com/cloud/stack/CloudStackQueryBuilder.java PRE-CREATION
> awsapi/test/com/cloud/gate/util/CloudStackClientTestCase.java 826cb3a
> awsapi/test/com/cloud/gate/util/JsonAccessorTestCase.java 8603e59
> awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17586/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> cloudstack_api_post_and_ssl_fix.patch
> https://reviews.apache.org/media/uploaded/files/2014/04/21/93dfe17d-2f7f-4413-80ba-76d33a3b5a47__cloudstack_api_post_and_ssl_fix.patch
>
>
> Thanks,
>
> Dmitry Batkovich
>
>
Re: Review Request 17586: AWSAPI: cloudstack api on POST requests (instead
GET), ssl enabling fixed
Posted by Dmitry Batkovich <ba...@gmail.com>.
> On April 23, 2014, 12:41 p.m., daan Hoogland wrote:
> > awsapi/src/com/cloud/bridge/util/JsonElementUtil.java: seems to be there twice as well!?!
>
> Dmitry Batkovich wrote:
> I have written about it that "Update diff" works strange for me and I have attached patch to "File Attachments". In raw file I see only one JsonElementUtil and other classes...also it's good with licence headers
and now I have fixed code styles problems. patch in attachements
- Dmitry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17586/#review41138
-----------------------------------------------------------
On April 22, 2014, 10:50 p.m., Dmitry Batkovich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17586/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 10:50 p.m.)
>
>
> Review request for cloudstack, daan Hoogland and Sebastien Goasguen.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> * CloudStackClient.java http request mechanism replaced from GET requests to POST for supporting EC2 requests larger than 2KB
> * SSL enabling fixed in EC2Engine.java
>
>
> Diffs
> -----
>
> awsapi/conf/ec2-service.properties.in 82f5ad8
> awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java cd20214
> awsapi/src/com/cloud/bridge/util/JsonAccessor.java 2a94dea
> awsapi/src/com/cloud/bridge/util/JsonElementUtil.java PRE-CREATION
> awsapi/src/com/cloud/bridge/util/JsonElementUtil.java 2d8afb5
> awsapi/src/com/cloud/stack/CloudStackApi.java b7a1210
> awsapi/src/com/cloud/stack/CloudStackClient.java 03eba96
> awsapi/src/com/cloud/stack/CloudStackClientException.java PRE-CREATION
> awsapi/src/com/cloud/stack/CloudStackClientException.java ac1b3ef
> awsapi/src/com/cloud/stack/CloudStackCommand.java 8d6aa68
> awsapi/src/com/cloud/stack/CloudStackQueryBuilder.java PRE-CREATION
> awsapi/test/com/cloud/gate/util/CloudStackClientTestCase.java 826cb3a
> awsapi/test/com/cloud/gate/util/JsonAccessorTestCase.java 8603e59
> awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17586/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> cloudstack_api_post_and_ssl_fix.patch
> https://reviews.apache.org/media/uploaded/files/2014/04/21/93dfe17d-2f7f-4413-80ba-76d33a3b5a47__cloudstack_api_post_and_ssl_fix.patch
>
>
> Thanks,
>
> Dmitry Batkovich
>
>
Re: Review Request 17586: AWSAPI: cloudstack api on POST requests (instead
GET), ssl enabling fixed
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17586/#review41138
-----------------------------------------------------------
awsapi/src/com/cloud/bridge/util/JsonElementUtil.java: seems to be there twice as well!?!
- daan Hoogland
On April 22, 2014, 10:50 p.m., Dmitry Batkovich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17586/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 10:50 p.m.)
>
>
> Review request for cloudstack, daan Hoogland and Sebastien Goasguen.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> * CloudStackClient.java http request mechanism replaced from GET requests to POST for supporting EC2 requests larger than 2KB
> * SSL enabling fixed in EC2Engine.java
>
>
> Diffs
> -----
>
> awsapi/conf/ec2-service.properties.in 82f5ad8
> awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java cd20214
> awsapi/src/com/cloud/bridge/util/JsonAccessor.java 2a94dea
> awsapi/src/com/cloud/bridge/util/JsonElementUtil.java PRE-CREATION
> awsapi/src/com/cloud/bridge/util/JsonElementUtil.java 2d8afb5
> awsapi/src/com/cloud/stack/CloudStackApi.java b7a1210
> awsapi/src/com/cloud/stack/CloudStackClient.java 03eba96
> awsapi/src/com/cloud/stack/CloudStackClientException.java PRE-CREATION
> awsapi/src/com/cloud/stack/CloudStackClientException.java ac1b3ef
> awsapi/src/com/cloud/stack/CloudStackCommand.java 8d6aa68
> awsapi/src/com/cloud/stack/CloudStackQueryBuilder.java PRE-CREATION
> awsapi/test/com/cloud/gate/util/CloudStackClientTestCase.java 826cb3a
> awsapi/test/com/cloud/gate/util/JsonAccessorTestCase.java 8603e59
> awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17586/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> cloudstack_api_post_and_ssl_fix.patch
> https://reviews.apache.org/media/uploaded/files/2014/04/21/93dfe17d-2f7f-4413-80ba-76d33a3b5a47__cloudstack_api_post_and_ssl_fix.patch
>
>
> Thanks,
>
> Dmitry Batkovich
>
>
Re: Review Request 17586: AWSAPI: cloudstack api on POST requests (instead
GET), ssl enabling fixed
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17586/#review41135
-----------------------------------------------------------
it seems awsapi/src/com/cloud/stack/CloudStackClientException.java is in this patch twice!?! Can you check the patch?
awsapi/src/com/cloud/bridge/util/JsonElementUtil.java
<https://reviews.apache.org/r/17586/#comment74549>
license header needed
awsapi/src/com/cloud/stack/CloudStackClientException.java
<https://reviews.apache.org/r/17586/#comment74550>
license header needed
awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java
<https://reviews.apache.org/r/17586/#comment74551>
please apply the coding conventions (no tabs)
awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java
<https://reviews.apache.org/r/17586/#comment74552>
please apply the coding conventions (no trailing spaces)
- daan Hoogland
On April 22, 2014, 10:50 p.m., Dmitry Batkovich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17586/
> -----------------------------------------------------------
>
> (Updated April 22, 2014, 10:50 p.m.)
>
>
> Review request for cloudstack, daan Hoogland and Sebastien Goasguen.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> * CloudStackClient.java http request mechanism replaced from GET requests to POST for supporting EC2 requests larger than 2KB
> * SSL enabling fixed in EC2Engine.java
>
>
> Diffs
> -----
>
> awsapi/conf/ec2-service.properties.in 82f5ad8
> awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java cd20214
> awsapi/src/com/cloud/bridge/util/JsonAccessor.java 2a94dea
> awsapi/src/com/cloud/bridge/util/JsonElementUtil.java PRE-CREATION
> awsapi/src/com/cloud/bridge/util/JsonElementUtil.java 2d8afb5
> awsapi/src/com/cloud/stack/CloudStackApi.java b7a1210
> awsapi/src/com/cloud/stack/CloudStackClient.java 03eba96
> awsapi/src/com/cloud/stack/CloudStackClientException.java PRE-CREATION
> awsapi/src/com/cloud/stack/CloudStackClientException.java ac1b3ef
> awsapi/src/com/cloud/stack/CloudStackCommand.java 8d6aa68
> awsapi/src/com/cloud/stack/CloudStackQueryBuilder.java PRE-CREATION
> awsapi/test/com/cloud/gate/util/CloudStackClientTestCase.java 826cb3a
> awsapi/test/com/cloud/gate/util/JsonAccessorTestCase.java 8603e59
> awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17586/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> cloudstack_api_post_and_ssl_fix.patch
> https://reviews.apache.org/media/uploaded/files/2014/04/21/93dfe17d-2f7f-4413-80ba-76d33a3b5a47__cloudstack_api_post_and_ssl_fix.patch
>
>
> Thanks,
>
> Dmitry Batkovich
>
>
Re: Review Request 17586: AWSAPI: cloudstack api on POST requests (instead
GET), ssl enabling fixed
Posted by Dmitry Batkovich <ba...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17586/
-----------------------------------------------------------
(Updated April 22, 2014, 10:50 p.m.)
Review request for cloudstack, daan Hoogland and Sebastien Goasguen.
Repository: cloudstack-git
Description
-------
* CloudStackClient.java http request mechanism replaced from GET requests to POST for supporting EC2 requests larger than 2KB
* SSL enabling fixed in EC2Engine.java
Diffs
-----
awsapi/conf/ec2-service.properties.in 82f5ad8
awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java cd20214
awsapi/src/com/cloud/bridge/util/JsonAccessor.java 2a94dea
awsapi/src/com/cloud/bridge/util/JsonElementUtil.java PRE-CREATION
awsapi/src/com/cloud/bridge/util/JsonElementUtil.java 2d8afb5
awsapi/src/com/cloud/stack/CloudStackApi.java b7a1210
awsapi/src/com/cloud/stack/CloudStackClient.java 03eba96
awsapi/src/com/cloud/stack/CloudStackClientException.java PRE-CREATION
awsapi/src/com/cloud/stack/CloudStackClientException.java ac1b3ef
awsapi/src/com/cloud/stack/CloudStackCommand.java 8d6aa68
awsapi/src/com/cloud/stack/CloudStackQueryBuilder.java PRE-CREATION
awsapi/test/com/cloud/gate/util/CloudStackClientTestCase.java 826cb3a
awsapi/test/com/cloud/gate/util/JsonAccessorTestCase.java 8603e59
awsapi/test/com/cloud/gate/util/JsonElementUtilTestCase.java PRE-CREATION
Diff: https://reviews.apache.org/r/17586/diff/
Testing
-------
File Attachments
----------------
cloudstack_api_post_and_ssl_fix.patch
https://reviews.apache.org/media/uploaded/files/2014/04/21/93dfe17d-2f7f-4413-80ba-76d33a3b5a47__cloudstack_api_post_and_ssl_fix.patch
Thanks,
Dmitry Batkovich