You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/10/31 12:57:59 UTC
[PR] Clean up predicate_cache tests [arrow-rs]
alamb opened a new pull request, #8755:
URL: https://github.com/apache/arrow-rs/pull/8755
- Draft as it builds on https://github.com/apache/arrow-rs/pull/8754
# Which issue does this PR close?
- Follow on to https://github.com/apache/arrow-rs/pull/8754
# Rationale for this change
While working on https://github.com/apache/arrow-rs/pull/8754 I found the current formulation a bit akward so let's fix that
# What changes are included in this PR?
Move the builder configuration to a trait so the tests read more fluently.
This is totally unecessary, it just makes me feel better about the tests
# Are these changes tested?
Yes by CI
# Are there any user-facing changes?
No this is test only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clean up predicate_cache tests [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #8755:
URL: https://github.com/apache/arrow-rs/pull/8755#issuecomment-3513615146
Thank you @etseidl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clean up predicate_cache tests [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #8755:
URL: https://github.com/apache/arrow-rs/pull/8755#discussion_r2481336757
##########
parquet/tests/arrow_reader/predicate_cache.rs:
##########
@@ -52,8 +52,7 @@ async fn test_default_read() {
#[tokio::test]
async fn test_async_cache_with_filters() {
let test = ParquetPredicateCacheTest::new().with_expected_records_read_from_cache(49);
- let async_builder = test.async_builder().await;
- let async_builder = test.add_project_ab_and_filter_b(async_builder);
+ let async_builder = test.async_builder().await.add_project_ab_and_filter_b();
Review Comment:
This is the key change -- move the logic to add specific filters to an extension trait rather than a methog on the `ParquetPredicateCacheTest` test fixture
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clean up predicate_cache tests [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #8755:
URL: https://github.com/apache/arrow-rs/pull/8755#discussion_r2483545732
##########
parquet/tests/arrow_reader/predicate_cache.rs:
##########
@@ -154,53 +155,6 @@ impl ParquetPredicateCacheTest {
.unwrap()
}
- /// Return a [`ParquetRecordBatchReaderBuilder`] for reading the file with
Review Comment:
this code was moved to a new trait -- but the logic is the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clean up predicate_cache tests [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #8755:
URL: https://github.com/apache/arrow-rs/pull/8755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org