You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Eli Collins (Commented) (JIRA)" <ji...@apache.org> on 2011/11/21 07:52:51 UTC
[jira] [Commented] (MAPREDUCE-3424) Some LinuxTaskController
cleanup
[ https://issues.apache.org/jira/browse/MAPREDUCE-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154023#comment-13154023 ]
Eli Collins commented on MAPREDUCE-3424:
----------------------------------------
{noformat}
[exec]
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.
[exec]
{noformat}
The findbugs warning came from a previous change (see them w/ a null patch). Existing tests suffice since this is cleanup.
> Some LinuxTaskController cleanup
> --------------------------------
>
> Key: MAPREDUCE-3424
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3424
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: tasktracker
> Affects Versions: 0.20.205.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: mapreduce-3424-1.patch, mapreduce-3424-2.patch, mapreduce-3424-3.patch
>
>
> MR-2415 had some tabs and weird indenting and spacing. Also would be more clear if LTC explicitly overrides createLogDir. Let's clean this up.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira