You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@wicket.apache.org by Steffen Fritzsche <fr...@scriptroom.de> on 2010/11/30 15:45:20 UTC
Why is method "getLastModified" in WicketFilter package-protected?
Hi,
Why is the method "getLastModified" in WicketFilter package-protected?
My problem is that I extend WicketFilter in an OSGi context. I'd like to delegate all calls to my own "getLastModified" method to the underlying WicketFilter. Since I am in an OSGi context and the package "org.apache.wicket.protocol.http" is already exported by the wicket core osgi bundle I can not simply put my class in the same package, nor can I place a small wrapper class in this package which increases the method visibility.
So, question is if there are any side effects which justify that I can't delegate to this method. I don't see any. Maybe it makes sense to increase the visibility of this method.
The same problem exists with parameter SERVLET_PATH_HOLDER in WicketFilter. Since this is only a parameter one could easily copy it, but since it is final already why not make it public? Or at least protected to use it in Subclasses?
Regards,
Steffen
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Why is method "getLastModified" in WicketFilter package-protected?
Posted by Steffen Fritzsche <fr...@scriptroom.de>.
I've switched to 1.4.14 where the getLastModified-Method is already declared "protected". That solves my problem :)
-sf
Am 30.11.2010 um 16:49 schrieb Steffen Fritzsche:
> I'm using 1.4.13, where the method is still package-protected. I've seen right now that 1.4.14 was released yesterday, is it changed there already?
>
> Yes, I'm completely rewriting the init-method for my filter, because I have to take into account some Osgi and Spring specific issues.
>
> Why is this method removed in 1.5? In my opinion it makes sense to override this HttpServlet method to indicate site changes.
>
> -sf
>
>
> Am 30.11.2010 um 16:12 schrieb Martin Grigorov:
>
>> Which version of Wicket do you use ?
>> In latest 1.4-SNAPSHOT it is "protected". In 1.5 this method does not even
>> exists anymore.
>> The same for SERVLET_PATH_HOLDER. This one is used in WicketFilter#init()
>> and WicketServlet#init(). Do you completely re-write those ?
>>
>> On Tue, Nov 30, 2010 at 3:45 PM, Steffen Fritzsche
>> <fr...@scriptroom.de>wrote:
>>
>>> Hi,
>>>
>>> Why is the method "getLastModified" in WicketFilter package-protected?
>>>
>>> My problem is that I extend WicketFilter in an OSGi context. I'd like to
>>> delegate all calls to my own "getLastModified" method to the underlying
>>> WicketFilter. Since I am in an OSGi context and the package
>>> "org.apache.wicket.protocol.http" is already exported by the wicket core
>>> osgi bundle I can not simply put my class in the same package, nor can I
>>> place a small wrapper class in this package which increases the method
>>> visibility.
>>>
>>> So, question is if there are any side effects which justify that I can't
>>> delegate to this method. I don't see any. Maybe it makes sense to increase
>>> the visibility of this method.
>>>
>>> The same problem exists with parameter SERVLET_PATH_HOLDER in WicketFilter.
>>> Since this is only a parameter one could easily copy it, but since it is
>>> final already why not make it public? Or at least protected to use it in
>>> Subclasses?
>>>
>>> Regards,
>>> Steffen
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>>> For additional commands, e-mail: users-help@wicket.apache.org
>>>
>>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Why is method "getLastModified" in WicketFilter package-protected?
Posted by Steffen Fritzsche <fr...@scriptroom.de>.
I'm using 1.4.13, where the method is still package-protected. I've seen right now that 1.4.14 was released yesterday, is it changed there already?
Yes, I'm completely rewriting the init-method for my filter, because I have to take into account some Osgi and Spring specific issues.
Why is this method removed in 1.5? In my opinion it makes sense to override this HttpServlet method to indicate site changes.
-sf
Am 30.11.2010 um 16:12 schrieb Martin Grigorov:
> Which version of Wicket do you use ?
> In latest 1.4-SNAPSHOT it is "protected". In 1.5 this method does not even
> exists anymore.
> The same for SERVLET_PATH_HOLDER. This one is used in WicketFilter#init()
> and WicketServlet#init(). Do you completely re-write those ?
>
> On Tue, Nov 30, 2010 at 3:45 PM, Steffen Fritzsche
> <fr...@scriptroom.de>wrote:
>
>> Hi,
>>
>> Why is the method "getLastModified" in WicketFilter package-protected?
>>
>> My problem is that I extend WicketFilter in an OSGi context. I'd like to
>> delegate all calls to my own "getLastModified" method to the underlying
>> WicketFilter. Since I am in an OSGi context and the package
>> "org.apache.wicket.protocol.http" is already exported by the wicket core
>> osgi bundle I can not simply put my class in the same package, nor can I
>> place a small wrapper class in this package which increases the method
>> visibility.
>>
>> So, question is if there are any side effects which justify that I can't
>> delegate to this method. I don't see any. Maybe it makes sense to increase
>> the visibility of this method.
>>
>> The same problem exists with parameter SERVLET_PATH_HOLDER in WicketFilter.
>> Since this is only a parameter one could easily copy it, but since it is
>> final already why not make it public? Or at least protected to use it in
>> Subclasses?
>>
>> Regards,
>> Steffen
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>> For additional commands, e-mail: users-help@wicket.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: Why is method "getLastModified" in WicketFilter package-protected?
Posted by Martin Grigorov <mg...@apache.org>.
Which version of Wicket do you use ?
In latest 1.4-SNAPSHOT it is "protected". In 1.5 this method does not even
exists anymore.
The same for SERVLET_PATH_HOLDER. This one is used in WicketFilter#init()
and WicketServlet#init(). Do you completely re-write those ?
On Tue, Nov 30, 2010 at 3:45 PM, Steffen Fritzsche
<fr...@scriptroom.de>wrote:
> Hi,
>
> Why is the method "getLastModified" in WicketFilter package-protected?
>
> My problem is that I extend WicketFilter in an OSGi context. I'd like to
> delegate all calls to my own "getLastModified" method to the underlying
> WicketFilter. Since I am in an OSGi context and the package
> "org.apache.wicket.protocol.http" is already exported by the wicket core
> osgi bundle I can not simply put my class in the same package, nor can I
> place a small wrapper class in this package which increases the method
> visibility.
>
> So, question is if there are any side effects which justify that I can't
> delegate to this method. I don't see any. Maybe it makes sense to increase
> the visibility of this method.
>
> The same problem exists with parameter SERVLET_PATH_HOLDER in WicketFilter.
> Since this is only a parameter one could easily copy it, but since it is
> final already why not make it public? Or at least protected to use it in
> Subclasses?
>
> Regards,
> Steffen
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>