Re: [PR] [#1628] fix: Retain netty byteBuf when decoding [incubator-uniffle]

["wForget (via GitHub)" <gi...@apache.org>]

wForget commented on PR #1849:
URL: https://github.com/apache/incubator-uniffle/pull/1849#issuecomment-2205888556

   > If I get this correctly:
   > 
   > before decoding --> `refCnt` is `1` after decoding --> `refCnt` is `1` (keep still) business codes call `release()` --> `refCnt` is `0`
   > 
   > If you call `retain`, then the process will be: before decoding --> `refCnt` is `1` after decoding --> `refCnt` is `2` (calling `retain()`) business codes call `release()` --> `refCnt` is `1`
   > 
   > Then, there will be memory leaks. Right?
   
   Thanks for the explanation, that makes sense, I seemed to have misunderstood this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org