You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/23 17:00:25 UTC

[GitHub] [superset] Antonio-RiveroMartnez commented on a diff in pull request #21165: feat: Update Data Infra Architecture in the Nav Bar

Antonio-RiveroMartnez commented on code in PR #21165:
URL: https://github.com/apache/superset/pull/21165#discussion_r952893698


##########
superset/initialization/__init__.py:
##########
@@ -331,13 +344,14 @@ def init_views(self) -> None:
             category_icon="fa-flask",
             icon="fa-flask",
             category="SQL Lab",
-            category_label=__("SQL Lab"),
+            category_label=__("SQL"),

Review Comment:
   Does this change impact the `SQLLAB_PERMISSION_VIEWS` and `ADMIN_ONLY_VIEW_MENUS` in the security manager?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org