You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/29 20:52:11 UTC

[GitHub] [incubator-superset] codecov-io commented on pull request #9684: fix: migrate all slices off the old time grain format

codecov-io commented on pull request #9684:
URL: https://github.com/apache/incubator-superset/pull/9684#issuecomment-621457401


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9684?src=pr&el=h1) Report
   > Merging [#9684](https://codecov.io/gh/apache/incubator-superset/pull/9684?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f13ba2561cd325c4bd4dc3c4700b618f195b89ed&el=desc) will **decrease** coverage by `6.97%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9684/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9684?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9684      +/-   ##
   ==========================================
   - Coverage   65.75%   58.77%   -6.98%     
   ==========================================
     Files         581      399     -182     
     Lines       30319    12508   -17811     
     Branches     3096     3095       -1     
   ==========================================
   - Hits        19937     7352   -12585     
   + Misses      10201     4975    -5226     
     Partials      181      181              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `58.77% <ø> (-0.02%)` | :arrow_down: |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9684?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9684/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9BZGhvY0ZpbHRlckNvbnRyb2wuanN4) | `59.22% <0.00%> (-1.57%)` | :arrow_down: |
   | [superset/utils/import\_datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/9684/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvaW1wb3J0X2RhdGFzb3VyY2UucHk=) | | |
   | [superset/db\_engine\_specs/kylin.py](https://codecov.io/gh/apache/incubator-superset/pull/9684/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2t5bGluLnB5) | | |
   | [superset/views/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9684/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZmlsdGVycy5weQ==) | | |
   | [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9684/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | | |
   | [superset/models/slice.py](https://codecov.io/gh/apache/incubator-superset/pull/9684/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NsaWNlLnB5) | | |
   | [superset/models/datasource\_access\_request.py](https://codecov.io/gh/apache/incubator-superset/pull/9684/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2RhdGFzb3VyY2VfYWNjZXNzX3JlcXVlc3QucHk=) | | |
   | [superset/views/database/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/9684/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZmlsdGVycy5weQ==) | | |
   | [superset/charts/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/9684/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2J1bGtfZGVsZXRlLnB5) | | |
   | [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9684/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | | |
   | ... and [173 more](https://codecov.io/gh/apache/incubator-superset/pull/9684/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9684?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9684?src=pr&el=footer). Last update [f13ba25...120fc86](https://codecov.io/gh/apache/incubator-superset/pull/9684?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org