You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/10 07:38:28 UTC

[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11393: [Fix] Fix Environment variable data error

EricGao888 commented on code in PR #11393:
URL: https://github.com/apache/dolphinscheduler/pull/11393#discussion_r942121382


##########
.github/workflows/cluster-test/mysql/dolphinscheduler_env.sh:
##########
@@ -15,6 +15,9 @@
 # limitations under the License.
 #
 
+# Load system configuration
+source /etc/profile

Review Comment:
   I don't like the idea to `source /etc/profile` either. Some users may put their real `profile` files in a different path, in that case, `source /etc/profile` may cause some big trouble.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org