You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Kenneth Giusti <kg...@apache.org> on 2013/06/28 22:50:58 UTC
Review Request 12178: Provide accessors for distribution mode in source
terminus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12178/
-----------------------------------------------------------
Review request for qpid, Gordon Sim, Rob Godfrey, and Rafael Schloming.
Bugs: proton-139
https://issues.apache.org/jira/browse/proton-139
Repository: qpid
Description
-------
Add simple api to get/set the distribution mode on a terminus.
Diffs
-----
/proton/trunk/proton-c/bindings/python/proton.py 1497342
/proton/trunk/proton-c/include/proton/engine.h 1497342
/proton/trunk/proton-c/src/engine/engine-internal.h 1497342
/proton/trunk/proton-c/src/engine/engine.c 1497342
/proton/trunk/proton-j/proton-api/src/main/resources/proton.py 1497342
/proton/trunk/tests/python/proton_tests/engine.py 1497342
Diff: https://reviews.apache.org/r/12178/diff/
Testing
-------
New unit test added.
Thanks,
Kenneth Giusti
Re: Review Request 12178: Provide accessors for distribution mode in source
terminus
Posted by Gordon Sim <gs...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12178/#review22761
-----------------------------------------------------------
Ship it!
Looks great, thanks Ken!
- Gordon Sim
On June 28, 2013, 8:50 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12178/
> -----------------------------------------------------------
>
> (Updated June 28, 2013, 8:50 p.m.)
>
>
> Review request for qpid, Gordon Sim, Rob Godfrey, and Rafael Schloming.
>
>
> Bugs: proton-139
> https://issues.apache.org/jira/browse/proton-139
>
>
> Repository: qpid
>
>
> Description
> -------
>
> Add simple api to get/set the distribution mode on a terminus.
>
>
> Diffs
> -----
>
> /proton/trunk/proton-c/bindings/python/proton.py 1497342
> /proton/trunk/proton-c/include/proton/engine.h 1497342
> /proton/trunk/proton-c/src/engine/engine-internal.h 1497342
> /proton/trunk/proton-c/src/engine/engine.c 1497342
> /proton/trunk/proton-j/proton-api/src/main/resources/proton.py 1497342
> /proton/trunk/tests/python/proton_tests/engine.py 1497342
>
> Diff: https://reviews.apache.org/r/12178/diff/
>
>
> Testing
> -------
>
> New unit test added.
>
>
> Thanks,
>
> Kenneth Giusti
>
>