You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by eymorale <gi...@git.apache.org> on 2014/11/04 19:41:02 UTC
[GitHub] cordova-ios pull request: CB-5706 convert some of the bash scripts...
GitHub user eymorale opened a pull request:
https://github.com/apache/cordova-ios/pull/118
CB-5706 convert some of the bash scripts to nodejs
only converted the ones necessary to allow iOS project management on a nonsupported OS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eymorale/cordova-ios CB-5706
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/118.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #118
----
commit dad06bde2aca45b2ba459fe83a93726f1b736c85
Author: Edna Morales <ed...@gmail.com>
Date: 2014-11-03T20:18:05Z
CB-5706 convert some of the bash scripts to nodejs
commit 94acbf4224058ef02668787f983cea2780cbc7d8
Author: Edna Morales <ed...@gmail.com>
Date: 2014-11-04T18:33:50Z
CB-5706 Add which and q to checked-in node_modules
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-5706 convert some of the bash scripts...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/118#issuecomment-61882670
looks good to me for OS X, tested it lightly, I'll trust that it works on Windows (don't have capability to test it at the moment)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [GitHub] cordova-ios pull request: CB-5706 convert some of the
bash scripts...
Posted by Jesse <pu...@gmail.com>.
Next test, one of you commit a project that includes a plugin, + ios +
windows platforms, and see if the other can build/run it ...
@purplecabbage
risingj.com
On Wed, Nov 5, 2014 at 2:20 PM, martincgg <gi...@git.apache.org> wrote:
> Github user martincgg commented on the pull request:
>
> https://github.com/apache/cordova-ios/pull/118#issuecomment-61892049
>
> Correct, I performed some testing over Windows platform, it worked
> like a charm.
> I ran some commands as: create, platform add, plugin add.
> After that I added the android platform, no conflict at all.
> Added a new plugin and it got installed in both platforms.
>
> Check each folder, at native and www as well, files are in place.
> Correct references at plugin\ios.json file.
>
> Also I ran, the cordova run ios as well, throws a error trying to run
> that over windows, which is expected.
> It looked good to me.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
[GitHub] cordova-ios pull request: CB-5706 convert some of the bash scripts...
Posted by martincgg <gi...@git.apache.org>.
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-ios/pull/118#issuecomment-61892049
Correct, I performed some testing over Windows platform, it worked like a charm.
I ran some commands as: create, platform add, plugin add.
After that I added the android platform, no conflict at all.
Added a new plugin and it got installed in both platforms.
Check each folder, at native and www as well, files are in place.
Correct references at plugin\ios.json file.
Also I ran, the cordova run ios as well, throws a error trying to run that over windows, which is expected.
It looked good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-5706 convert some of the bash scripts...
Posted by eymorale <gi...@git.apache.org>.
Github user eymorale commented on the pull request:
https://github.com/apache/cordova-ios/pull/118#issuecomment-61998319
Sure thing. Fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-5706 convert some of the bash scripts...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/118
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-5706 convert some of the bash scripts...
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-ios/pull/118#issuecomment-61902405
Had a scan over the code and nothing jumped out as unusual :). Only thing is it'd be good to use 4 space indent since that's the prevailing style everywhere else.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-5706 convert some of the bash scripts...
Posted by eymorale <gi...@git.apache.org>.
Github user eymorale commented on the pull request:
https://github.com/apache/cordova-ios/pull/118#issuecomment-61886196
Thanks @shazron . I had someone test it on Windows, then I pulled their project to my Mac and made sure that the project would build and run when created from Windows. It looked good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org