[jira] [Commented] (BEAM-2736) Dataflow ValidatesRunner tests are failing MetricsTests

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-2736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116820#comment-16116820 ] 

ASF GitHub Bot commented on BEAM-2736:
--------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/3695

    [BEAM-2736] Suppress Attempted Metrics tests in Dataflow Batch

    Batch does not support attempted metrics, only committed and tentative.
    
    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
     - [ ] Each commit in the pull request should have a meaningful subject line and body.
     - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
     - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
     - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam attempted_metrics_dataflow

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3695.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3695
    
----
commit 31677e53526b2f35a194c3c5adc9fb4257488023
Author: Thomas Groh <tg...@google.com>
Date:   2017-08-07T16:27:46Z

    Suppress Attempted Metrics tests in Dataflow Batch
    
    Batch does not support attempted metrics, only committed and tentative.

----


> Dataflow ValidatesRunner tests are failing MetricsTests
> -------------------------------------------------------
>
>                 Key: BEAM-2736
>                 URL: https://issues.apache.org/jira/browse/BEAM-2736
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>
> The tests testAttemptedCounterMetrics, testBoundedSourceMetrics, testUnboundedSourceMetrics all look for attempted metrics at a step in the pipeline. The Pipeline produces metrics with appropriate values.
> This may be a simple misconfiguration, and the batch suite of {{ValidatesRunner}} tests should suppress "attempted" values (my understanding is that as of pipeline completion only committed values should be returned.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)