[jira] [Commented] (FLINK-6400) Lack of protection accessing masterHooks in CheckpointCoordinator#triggerCheckpoint

["Stephan Ewen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987605#comment-15987605 ] 

Stephan Ewen commented on FLINK-6400:
-------------------------------------

I think this is a theoretical issue more. The hooks are not manipulated after the coordinator is instantiated.

Will patch this anyways, to make the code clear...

> Lack of protection accessing masterHooks in CheckpointCoordinator#triggerCheckpoint
> -----------------------------------------------------------------------------------
>
>                 Key: FLINK-6400
>                 URL: https://issues.apache.org/jira/browse/FLINK-6400
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> Here is related code:
> {code}
>     synchronized (triggerLock) {
> ...
>       try {
>         List<MasterState> masterStates = MasterHooks.triggerMasterHooks(masterHooks.values(),
> {code}
> masterHooks is protected by lock in other methods while triggerLock is only used in CheckpointCoordinator#triggerCheckpoint()



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)