You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/04/09 15:40:00 UTC
[jira] [Work logged] (BEAM-3279) Deprecate and remove Coder
consistentWithEquals in favor of overriding structuredValue
[ https://issues.apache.org/jira/browse/BEAM-3279?focusedWorklogId=225058&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-225058 ]
ASF GitHub Bot logged work on BEAM-3279:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/19 15:39
Start Date: 09/Apr/19 15:39
Worklog Time Spent: 10m
Work Description: kennknowles commented on issue #8071: [BEAM-3279] Deprecate and remove Coder.consistentWithEquals
URL: https://github.com/apache/beam/pull/8071#issuecomment-481305756
Congratulations! This change (which is good) exposed a critical bug in the core SDK. We may have to roll this back, hopefully only temporarily, while we figure out what to do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 225058)
Time Spent: 5h (was: 4h 50m)
> Deprecate and remove Coder consistentWithEquals in favor of overriding structuredValue
> --------------------------------------------------------------------------------------
>
> Key: BEAM-3279
> URL: https://issues.apache.org/jira/browse/BEAM-3279
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Alexander Savchenko
> Priority: Minor
> Labels: starter
> Time Spent: 5h
> Remaining Estimate: 0h
>
> Summary of discussion linked below:
> consistentWithEquals() is redundant w.r.t. structuralValue(), and should be deprecated. I think our mutation detectors are already using structuralValue(), so the work here would be to simply mark the method deprecated, remove all remaining overrides in the SDK, and document that overriding the method is a no-op.
> https://lists.apache.org/thread.html/8b2dcf09ba8e46b3c008293d99e4028d10463148b68326687dc29a4d@%3Cdev.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)