[GitHub] [pinot] walterddr commented on a diff in pull request #10384: Refactor: Simplify Execution Stats Aggregator

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10384:
URL: https://github.com/apache/pinot/pull/10384#discussion_r1155060974


##########
pinot-common/src/main/java/org/apache/pinot/common/datatable/DataTable.java:
##########
@@ -137,6 +137,7 @@ enum MetadataKey {
     // We keep this constant to track the max id added so far for backward compatibility.
     // Increase it when adding new keys, but NEVER DECREASE IT!!!
     private static final int MAX_ID = 31;
+    public static final String MULTI_VALUE_STRING_SEPARATOR = "::";

Review Comment:
   what's the intent here? why do we need to put this in DataTable MetadataKey?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org