You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/04/16 07:15:25 UTC
[GitHub] [cloudstack] cl-k-takahashi opened a new pull request #4034: Make
DB upgrade queries idempotent for convenience
cl-k-takahashi opened a new pull request #4034: Make DB upgrade queries idempotent for convenience
URL: https://github.com/apache/cloudstack/pull/4034
## Description
<!--- Describe your changes in detail -->
Make DB upgrade queries idempotent for convenience
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
Manually deleted 4.13.1.0 row from version table and re-started CloudStack management server.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] cl-k-takahashi commented on issue #4034: Make DB
upgrade queries idempotent for convenience
Posted by GitBox <gi...@apache.org>.
cl-k-takahashi commented on issue #4034: Make DB upgrade queries idempotent for convenience
URL: https://github.com/apache/cloudstack/pull/4034#issuecomment-614513633
It seems that MariaDB supports `DROP INDEX IF EXISTS` but MySQL doesn't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] cl-k-takahashi commented on issue #4034: Make DB
upgrade queries idempotent for convenience
Posted by GitBox <gi...@apache.org>.
cl-k-takahashi commented on issue #4034: Make DB upgrade queries idempotent for convenience
URL: https://github.com/apache/cloudstack/pull/4034#issuecomment-614501518
In my environment, `ALTER TABLE `region` DROP INDEX IF EXISTS `id_3`;` success but the travis ci seems to be failing...
```
mysql> select version();
+----------------------------------+
| version() |
+----------------------------------+
| 10.1.44-MariaDB-0ubuntu0.18.04.1 |
+----------------------------------+
1 row in set (0.00 sec)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services