You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/12 15:56:43 UTC

[GitHub] [kafka] chia7712 commented on a change in pull request #10119: Kip 695 revert

chia7712 commented on a change in pull request #10119:
URL: https://github.com/apache/kafka/pull/10119#discussion_r575312168



##########
File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
##########
@@ -144,7 +144,6 @@
     private static final long EOS_DEFAULT_COMMIT_INTERVAL_MS = 100L;
 
     public static final int DUMMY_THREAD_INDEX = 1;

Review comment:
       There are some refactor code related to KIP-695 (https://github.com/apache/kafka/commit/4d28391480fd8c547a63af119bba67fceb5d2ede#diff-07a8a87d3ee84c3e96918aa131033780cf4bc4d4a12ae376e91c059a9e02d229R142)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org