You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/05/04 17:51:31 UTC
[GitHub] [geode] jdeppe-pivotal opened a new pull request #5042: GEODE-8036: Do not block Netty threads when publishing
jdeppe-pivotal opened a new pull request #5042:
URL: https://github.com/apache/geode/pull/5042
- Now delegate PUBLISH responses to a background executor in order to
free up the Netty worker thread. This prevents possible deadlocks.
Co-authored-by: Murtuza Boxwala <mb...@vmware.com>
Co-authored-by: Ray Ingles <ri...@vmware.com>
Co-authored-by: Jens Deppe <jd...@vmware.com>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5042: GEODE-7998: Do not block Netty threads when publishing
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #5042:
URL: https://github.com/apache/geode/pull/5042#discussion_r421851477
##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/PubSubImpl.java
##########
@@ -91,6 +100,11 @@ public void execute(FunctionContext<Object[]> context) {
publishMessageToSubscribers((String) publishMessage[0], (byte[]) publishMessage[1]);
context.getResultSender().lastResult(subscriberCount);
}
+
+ @Override
Review comment:
Consider adding a comment as to why you don't want this function to be HA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal edited a comment on pull request #5042: GEODE-7998: Do not block Netty threads when publishing
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal edited a comment on pull request #5042:
URL: https://github.com/apache/geode/pull/5042#issuecomment-625864793
Test failure is unrelated and a known issue (https://issues.apache.org/jira/browse/GEODE-7738)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on pull request #5042: GEODE-7998: Do not block Netty threads when publishing
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on pull request #5042:
URL: https://github.com/apache/geode/pull/5042#issuecomment-625864793
Test failure is unrelated and a known issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org