[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2582: Upgrading GRPC version

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #2582:
URL: https://github.com/apache/bookkeeper/pull/2582#discussion_r572654979



##########
File path: pom.xml
##########
@@ -475,6 +476,27 @@
         <artifactId>grpc-all</artifactId>
         <version>${grpc.version}</version>
       </dependency>
+      <dependency>
+        <groupId>io.grpc</groupId>
+        <artifactId>grpc-netty-shaded</artifactId>
+        <version>${grpc.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>io.grpc</groupId>
+        <artifactId>grpc-protobuf</artifactId>
+        <version>${grpc.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>io.grpc</groupId>
+        <artifactId>grpc-stub</artifactId>
+        <version>${grpc.version}</version>
+      </dependency>
+      <dependency> <!-- necessary for Java 9+ -->
+        <groupId>org.apache.tomcat</groupId>
+        <artifactId>annotations-api</artifactId>
+        <version>${tomcat-annotations.version}</version>
+        <scope>provided</scope>
+      </dependency>

Review comment:
       This comment looks addressed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org