You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/12 11:57:59 UTC

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request, #9530: [Fix](Lateral View) Error view includes lateral view

EmmyMiao87 opened a new pull request, #9530:
URL: https://github.com/apache/incubator-doris/pull/9530

   Fixed #9529
   
   When the lateral view based on a inline view which belongs to a view,
   Doris could not resolve the column of lateral view.
   
   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem Summary:
   
   Describe the overview of changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: (Yes/No/I Don't know)
   2. Has unit tests been added: (Yes/No/No Need)
   3. Has document been added or modified: (Yes/No/No Need)
   4. Does it need to update dependencies: (Yes/No)
   5. Are there any changes that cannot be rolled back: (Yes/No)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] morningman merged pull request #9530: [Fix](Lateral View) Error view includes lateral view

Posted by GitBox <gi...@apache.org>.

morningman merged PR #9530:
URL: https://github.com/apache/incubator-doris/pull/9530


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] morrySnow commented on pull request #9530: [Fix](Lateral View) Error view includes lateral view

Posted by GitBox <gi...@apache.org>.

morrySnow commented on PR #9530:
URL: https://github.com/apache/incubator-doris/pull/9530#issuecomment-1125626042

   fe CheckStyle error need to be fixed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9530: [Fix](Lateral View) Error view includes lateral view

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #9530:
URL: https://github.com/apache/incubator-doris/pull/9530#issuecomment-1125581289

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9530: [Fix](Lateral View) Error view includes lateral view

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #9530:
URL: https://github.com/apache/incubator-doris/pull/9530#issuecomment-1125710139

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] morrySnow commented on a diff in pull request #9530: [Fix](Lateral View) Error view includes lateral view

Posted by GitBox <gi...@apache.org>.

morrySnow commented on code in PR #9530:
URL: https://github.com/apache/incubator-doris/pull/9530#discussion_r871973105


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/TableRef.java:
##########
@@ -627,20 +627,12 @@ public List<TupleId> getAllTableRefIds() {
     /**
      * Return the table ref presentation to be used in the toSql string
      */
+    // tbl1

Review Comment:
   write in java doc is better way



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9530: [Fix](Lateral View) Error view includes lateral view

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #9530:
URL: https://github.com/apache/incubator-doris/pull/9530#issuecomment-1125581271

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org