You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hive.apache.org by "Teddy Choi (Jira)" <ji...@apache.org> on 2022/07/14 13:48:00 UTC

[jira] [Commented] (HIVE-1626) stop using java.util.Stack

    [ https://issues.apache.org/jira/browse/HIVE-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17566850#comment-17566850 ] 

Teddy Choi commented on HIVE-1626:
----------------------------------

It's rewritten. A new pull request was created. It introduces an ArrayStack implementation for faster indexed accesses without synchronization.

> stop using java.util.Stack
> --------------------------
>
>                 Key: HIVE-1626
>                 URL: https://issues.apache.org/jira/browse/HIVE-1626
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 0.7.0
>            Reporter: John Sichi
>            Assignee: Teddy Choi
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-1626.2.patch, HIVE-1626.2.patch, HIVE-1626.3.patch, HIVE-1626.3.patch, HIVE-1626.3.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> We currently use Stack as part of the generic node walking library.  Stack should not be used for this since its inheritance from Vector incurs superfluous synchronization overhead.
> Most projects end up adding an ArrayStack implementation and using that instead.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)