You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by Spikhalskiy <gi...@git.apache.org> on 2015/11/10 14:52:09 UTC

[GitHub] commons-lang pull request: Fix indexOfIgnoreCase javadoc and provi...

GitHub user Spikhalskiy opened a pull request:

    https://github.com/apache/commons-lang/pull/115

    Fix indexOfIgnoreCase javadoc and provide test for fixed example

    Now javadoc for StringUtils#indexOfIgnoreCase contains example
    ```
    StringUtils.indexOfIgnoreCase("abc", "", 9) = 3
    ```
    This result is very unintuitive and incorrect - with current code it will be -1. Provided test for this example and fixed example's result in javadoc.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Spikhalskiy/commons-lang index-of-ignore-case-javadoc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #115
    
----
commit 4593b9672eacc4200aba4371e5ef406912952c2e
Author: Dmitry Spikhalskiy <dm...@spikhalskiy.com>
Date:   2015-11-10T13:47:31Z

    Fix indexOfIgnoreCase javadoc and provide test for fixed example

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Fix indexOfIgnoreCase javadoc and provi...

Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the pull request:

    https://github.com/apache/commons-lang/pull/115#issuecomment-209649478
  
    Patch applied. Thank you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Fix indexOfIgnoreCase javadoc and provi...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/commons-lang/pull/115


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---