You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/07/05 06:27:41 UTC

[GitHub] [echarts] Ovilia commented on pull request #17311: fix(axis): fix time axis labels and ticks being overlapped

Ovilia commented on PR #17311:
URL: https://github.com/apache/echarts/pull/17311#issuecomment-1174667488

   <img width="217" alt="image" src="https://user-images.githubusercontent.com/779050/177263277-0b88524f-ac92-48a6-bfc7-3196db7c5443.png">
   
   https://github.com/apache/echarts/pull/15583 's fixing may have a potential problem that the ticks of the overlapped labels are not hidden, so that the ticks are not always the same with the labels. @pissang Do you think it a better idea to avoid overlapping as in this PR so that the ticks are always the same with the labels?
   
   And after the change in #15712, it requires `hideOverlap` to avoid overlap, but I think this should be a default behavior (or at least the default value of `hideOverlap` of the axis labels should be set to be `true`). This should not considered as backward compatibility because the overlapped labels are bugs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org