You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/19 19:54:18 UTC

[GitHub] [spark] dongjoon-hyun edited a comment on issue #27534: [SPARK-30879][DOCS] Refine workflow for building docs

dongjoon-hyun edited a comment on issue #27534: [SPARK-30879][DOCS] Refine workflow for building docs
URL: https://github.com/apache/spark/pull/27534#issuecomment-588416416
 
 
   Got it. Then, it might be some misunderstanding. I thought you are aware of the community policies because you have been working in the community for a long time.
   1. First of all, we don't backport `Improvement`. The decision is made per PR.
   2. Due to (1), for improvement JIRAs, we had better use the version of master branch for `Affected Version`. In your case, you had better set `3.1.0` clearly when you register as `Improvement`.
   3. For the same ID PRs, we use the same JIRA ID for the related follow-up PRs only. And, in that case, we use `[FOLLOWUP]` tag in the PR title.
   
   Do you think your 3 PRs are follow-ups? For me, those are orthogonal. e.g., `Redefine workflow` is irrelevant to replace the deprecate `Mkdocs` option. The main reason why the committers ask to split is that you put orthogonal things into a single PR. It's bad not only for review, but also for understanding the commit logs. So, when you create a new PR like that, you need to create a new JIRA issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org