You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/09/13 02:15:42 UTC

[GitHub] [thrift] Jimexist opened a new pull request, #2661: fix staleness check in cmake/ctest

Jimexist opened a new pull request, #2661:
URL: https://github.com/apache/thrift/pull/2661

   <!-- Explain the changes in the pull request below: -->
   
   fix staleness check in cmake/ctest
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [ ] Did you squash your changes to a single commit?  (not required, but preferred)
   - [ ] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jimexist commented on pull request #2661: fix staleness check in cmake/ctest

Posted by GitBox <gi...@apache.org>.
Jimexist commented on PR #2661:
URL: https://github.com/apache/thrift/pull/2661#issuecomment-1244813386

   cmake flows failures will be caught by GitHub actions as well so we should rely on that to do fast sanity check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jimexist merged pull request #2661: fix staleness check in cmake/ctest

Posted by GitBox <gi...@apache.org>.
Jimexist merged PR #2661:
URL: https://github.com/apache/thrift/pull/2661


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G commented on pull request #2661: fix staleness check in cmake/ctest

Posted by GitBox <gi...@apache.org>.
Jens-G commented on PR #2661:
URL: https://github.com/apache/thrift/pull/2661#issuecomment-1245404910

   +1 thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org