You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by qiaoyun sun <su...@cn.ibm.com> on 2012/05/09 03:57:56 UTC
Re: Review Request: Add lang and country substitution for ifr in client side
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4906/
-----------------------------------------------------------
(Updated 2012-05-09 01:57:56.136560)
Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
Summary
-------
If we don't set this property in shindig.properties: shindig.urlgen.use-templates-default=false, the lang and country info will not pass to the ifr url, so the lang and country are ignored.
For example: the ifr is like :
http://localhost:8080/shindig/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fshindig%2Fsamplecontainer%2Fexamples%2FSocialHelloWorld.xml&container=default&view=default&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=0a811629d8d99f87d3544b65058211fe&st=john.doe%3Ajohn.doe%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fshindig%252Fsamplecontainer%252Fexamples%252FSocialHelloWorld.xml%3Acont%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fshindig%252Fsamplecontainer%252Fexamples%252FSocialHelloWorld.xml%3A0%3Adefault%3A1335423393&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0
They should be substituted by the browser's setting in client side.
This addresses bug SHINDIG-1763.
https://issues.apache.org/jira/browse/SHINDIG-1763
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1331177
Diff: https://reviews.apache.org/r/4906/diff
Testing
-------
Thanks,
qiaoyun
Re: Review Request: Add lang and country substitution for ifr in client side
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4906/#review7733
-----------------------------------------------------------
I am seeing JS Unit test failures in GadgetHolderTest.testRenderWithoutRenderParams and GadgetHolderTest.testRenderWithRenderRequests after applying this patch.
- Ryan
On 2012-05-09 01:57:56, qiaoyun sun wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4906/
> -----------------------------------------------------------
>
> (Updated 2012-05-09 01:57:56)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
>
>
> Summary
> -------
>
> If we don't set this property in shindig.properties: shindig.urlgen.use-templates-default=false, the lang and country info will not pass to the ifr url, so the lang and country are ignored.
> For example: the ifr is like :
> http://localhost:8080/shindig/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fshindig%2Fsamplecontainer%2Fexamples%2FSocialHelloWorld.xml&container=default&view=default&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=0a811629d8d99f87d3544b65058211fe&st=john.doe%3Ajohn.doe%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fshindig%252Fsamplecontainer%252Fexamples%252FSocialHelloWorld.xml%3Acont%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fshindig%252Fsamplecontainer%252Fexamples%252FSocialHelloWorld.xml%3A0%3Adefault%3A1335423393&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0
>
> They should be substituted by the browser's setting in client side.
>
>
> This addresses bug SHINDIG-1763.
> https://issues.apache.org/jira/browse/SHINDIG-1763
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1331177
>
> Diff: https://reviews.apache.org/r/4906/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> qiaoyun
>
>
Re: Review Request: Add lang and country substitution for ifr in client side
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4906/#review7762
-----------------------------------------------------------
Ship it!
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js
<https://reviews.apache.org/r/4906/#comment17071>
Small nit on trailing whitespace.
- Stanton
On 2012-05-10 06:49:27, qiaoyun sun wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4906/
> -----------------------------------------------------------
>
> (Updated 2012-05-10 06:49:27)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
>
>
> Summary
> -------
>
> If we don't set this property in shindig.properties: shindig.urlgen.use-templates-default=false, the lang and country info will not pass to the ifr url, so the lang and country are ignored.
> For example: the ifr is like :
> http://localhost:8080/shindig/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fshindig%2Fsamplecontainer%2Fexamples%2FSocialHelloWorld.xml&container=default&view=default&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=0a811629d8d99f87d3544b65058211fe&st=john.doe%3Ajohn.doe%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fshindig%252Fsamplecontainer%252Fexamples%252FSocialHelloWorld.xml%3Acont%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fshindig%252Fsamplecontainer%252Fexamples%252FSocialHelloWorld.xml%3A0%3Adefault%3A1335423393&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0
>
> They should be substituted by the browser's setting in client side.
>
>
> This addresses bug SHINDIG-1763.
> https://issues.apache.org/jira/browse/SHINDIG-1763
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1331177
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1331168
>
> Diff: https://reviews.apache.org/r/4906/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> qiaoyun
>
>
Re: Review Request: Add lang and country substitution for ifr in client side
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4906/#review7766
-----------------------------------------------------------
Ship it!
LGTM. I removed the whitespace for you. Please close the review.
Committed revision 1336646
- Ryan
On 2012-05-10 06:49:27, qiaoyun sun wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4906/
> -----------------------------------------------------------
>
> (Updated 2012-05-10 06:49:27)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
>
>
> Summary
> -------
>
> If we don't set this property in shindig.properties: shindig.urlgen.use-templates-default=false, the lang and country info will not pass to the ifr url, so the lang and country are ignored.
> For example: the ifr is like :
> http://localhost:8080/shindig/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fshindig%2Fsamplecontainer%2Fexamples%2FSocialHelloWorld.xml&container=default&view=default&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=0a811629d8d99f87d3544b65058211fe&st=john.doe%3Ajohn.doe%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fshindig%252Fsamplecontainer%252Fexamples%252FSocialHelloWorld.xml%3Acont%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fshindig%252Fsamplecontainer%252Fexamples%252FSocialHelloWorld.xml%3A0%3Adefault%3A1335423393&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0
>
> They should be substituted by the browser's setting in client side.
>
>
> This addresses bug SHINDIG-1763.
> https://issues.apache.org/jira/browse/SHINDIG-1763
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1331177
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1331168
>
> Diff: https://reviews.apache.org/r/4906/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> qiaoyun
>
>
Re: Review Request: Add lang and country substitution for ifr in client side
Posted by qiaoyun sun <su...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4906/
-----------------------------------------------------------
(Updated 2012-05-10 06:49:27.713021)
Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
Changes
-------
change the corresponding js unit test
Summary
-------
If we don't set this property in shindig.properties: shindig.urlgen.use-templates-default=false, the lang and country info will not pass to the ifr url, so the lang and country are ignored.
For example: the ifr is like :
http://localhost:8080/shindig/gadgets/ifr?url=http%3A%2F%2Flocalhost%3A8080%2Fshindig%2Fsamplecontainer%2Fexamples%2FSocialHelloWorld.xml&container=default&view=default&lang=%25lang%25&country=%25country%25&debug=1&nocache=1&sanitize=%25sanitize%25&v=0a811629d8d99f87d3544b65058211fe&st=john.doe%3Ajohn.doe%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fshindig%252Fsamplecontainer%252Fexamples%252FSocialHelloWorld.xml%3Acont%3Ahttp%253A%252F%252Flocalhost%253A8080%252Fshindig%252Fsamplecontainer%252Fexamples%252FSocialHelloWorld.xml%3A0%3Adefault%3A1335423393&testmode=0&parent=http%3A%2F%2Flocalhost%3A8080&mid=0
They should be substituted by the browser's setting in client side.
This addresses bug SHINDIG-1763.
https://issues.apache.org/jira/browse/SHINDIG-1763
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1331177
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1331168
Diff: https://reviews.apache.org/r/4906/diff
Testing
-------
Thanks,
qiaoyun