[GitHub] [hive] deniskuzZ commented on a change in pull request #3127: HIVE-26059: Eventually clean compactions in "refused" state from compaction history

[GitBox <gi...@apache.org>]

deniskuzZ commented on a change in pull request #3127:
URL: https://github.com/apache/hive/pull/3127#discussion_r833109424



##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java
##########
@@ -1092,16 +1092,18 @@ public void updateCompactorState(CompactionInfo ci, long compactionTxnId) throws
   }
 
   private static class RetentionCounters {
-    int didNotInitiateRetention = 0;
-    int failedRetention = 0;
-    int succeededRetention = 0;
+    int didNotInitiateRetention;

Review comment:
       should we mark them as final, to make sure they are initialized?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org