[GitHub] [tvm] areusch commented on a change in pull request #8021: [Fix][microTVM] QEMU RPC issue

[GitBox <gi...@apache.org>]

areusch commented on a change in pull request #8021:
URL: https://github.com/apache/tvm/pull/8021#discussion_r631156515



##########
File path: tests/micro/zephyr/conftest.py
##########
@@ -44,6 +44,18 @@ def pytest_addoption(parser):
     parser.addoption(
         "--west-cmd", default="west", help="Path to `west` command for flashing device."
     )
+    parser.addoption(
+        "--tvm-build",
+        action="store_true",
+        default=True,

Review comment:
       i think best not to checkin the test with this set default True. Maybe we can make it `--skip-build`? I don't think we have proper dependency tracking here.

##########
File path: tests/micro/zephyr/test_zephyr.py
##########
@@ -391,8 +389,42 @@ def test_byoc_utvm(platform, west_cmd):
         model=model,
         zephyr_board=zephyr_board,
         west_cmd=west_cmd,
+        build_config=build_config,
     )
 
 
+def _make_large_tensors_sess(model, zephyr_board, west_cmd, shape, build_config):

Review comment:
       the "large" part is just from the shape--maybe name as `_make_add_sess_with_shape`?

##########
File path: apps/microtvm/zephyr/demo_runtime/crt/crt_config.h
##########
@@ -42,7 +42,7 @@
 #define TVM_CRT_MAX_REGISTERED_MODULES 2
 
 /*! Maximum packet size, in bytes, including the length header. */
-#define TVM_CRT_MAX_PACKET_SIZE_BYTES 8192
+#define TVM_CRT_MAX_PACKET_SIZE_BYTES 4 * 1024

Review comment:
       add parens around the value, just in case

##########
File path: apps/microtvm/zephyr/demo_runtime/src/main.c
##########
@@ -214,7 +214,8 @@ tvm_crt_error_t TVMPlatformTimerStop(double* elapsed_time_seconds) {
 }
 
 // Ring buffer used to store data read from the UART on rx interrupt.
-#define RING_BUF_SIZE_BYTES 4 * 1024
+// Should be larger than TVM_CRT_MAX_PACKET_SIZE_BYTES

Review comment:
       can you comment how much larger, and why?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org