[GitHub] [inlong] thesumery commented on a diff in pull request #7118: [INLONG-7073][Sort] Support table level metrics for Apache Iceberg connector

[GitBox <gi...@apache.org>]

thesumery commented on code in PR #7118:
URL: https://github.com/apache/inlong/pull/7118#discussion_r1060301829


##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/metric/sub/SinkTableMetricData.java:
##########
@@ -228,6 +228,19 @@ public void outputDirtyMetrics(String database, String schema, String table, lon
         subSinkMetricData.invokeDirty(rowCount, rowSize);
     }
 
+    /**
+     * output dirty metrics with estimate
+     *
+     * @param database the database name of record
+     * @param schema the schema name of record
+     * @param table the table name of record
+     * @param data the dirty data
+     */
+    public void outputDirtyMetricsWithEstimate(String database, String schema, String table, Object data) {
+        long size = data.toString().getBytes(StandardCharsets.UTF_8).length;

Review Comment:
   ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org