You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/04/27 18:20:54 UTC
[GitHub] [nifi] sushilkm opened a new pull request #4236: NIFI-7389: Makes Missable heartbeat counts configurable
sushilkm opened a new pull request #4236:
URL: https://github.com/apache/nifi/pull/4236
#### Description of PR
Makes Missable heartbeat counts configurable; fixes NIFI-7389
Earlier the number was hardcoded as 8, this PR targets to make the count configurable via usage of 'nifi.cluster.protocol.heartbeat.max' in nifi.properties
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] alopresto commented on pull request #4236: NIFI-7389: Makes Missable heartbeat counts configurable
Posted by GitBox <gi...@apache.org>.
alopresto commented on pull request #4236:
URL: https://github.com/apache/nifi/pull/4236#issuecomment-620183696
Made a recommendation for changing the property name. Once that's done, I'll run the full build with tests and merge. Thanks for the contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] alopresto commented on a change in pull request #4236: NIFI-7389: Makes Missable heartbeat counts configurable
Posted by GitBox <gi...@apache.org>.
alopresto commented on a change in pull request #4236:
URL: https://github.com/apache/nifi/pull/4236#discussion_r416085004
##########
File path: nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java
##########
@@ -203,6 +203,7 @@
// cluster common properties
public static final String CLUSTER_PROTOCOL_HEARTBEAT_INTERVAL = "nifi.cluster.protocol.heartbeat.interval";
+ public static final String CLUSTER_PROTOCOL_HEARTBEAT_MAX = "nifi.cluster.protocol.heartbeat.max";
Review comment:
I think the property key should contain `missable` to indicate what the maximum _is_. Something like `CLUSTER_PROTOCOL_HEARTBEAT_MISSABLE_MAX = "nifi.cluster.protocol.heartbeat.missable.max";`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org