You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/07/07 06:18:20 UTC
[GitHub] [dubbo] TrueAbc opened a new pull request, #10282: 端口复用remoting层抽象的实现
TrueAbc opened a new pull request, #10282:
URL: https://github.com/apache/dubbo/pull/10282
## What is the purpose of the change
remoting-api相关的抽象类以及netty的实现
## Brief changelog
## Verifying this change
<!-- Follow this checklist to help us incorporate your contribution quickly and easily: -->
## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] EarthChen commented on pull request #10282: abstraction of remoting-api for port unification server
Posted by GitBox <gi...@apache.org>.
EarthChen commented on PR #10282:
URL: https://github.com/apache/dubbo/pull/10282#issuecomment-1178459850
I suggest to use the server `org.apache.dubbo.remoting.api.PortUnificationServer` of triple protocol directly to replace the current abstract server.
Migrate server implementations of other protocols directly to this server implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] CrazyHZM commented on a diff in pull request #10282: abstraction of remoting-api for port unification server
Posted by GitBox <gi...@apache.org>.
CrazyHZM commented on code in PR #10282:
URL: https://github.com/apache/dubbo/pull/10282#discussion_r916427438
##########
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/api/newportunification/NewWireProtocol.java:
##########
@@ -0,0 +1,16 @@
+package org.apache.dubbo.remoting.api.newportunification;
+
+import org.apache.dubbo.common.URL;
+import org.apache.dubbo.common.extension.ExtensionScope;
+import org.apache.dubbo.common.extension.SPI;
+
+@SPI(scope = ExtensionScope.FRAMEWORK)
+public interface NewWireProtocol {
Review Comment:
Do not create new ones, call the original abstract interface
##########
dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyTransporter.java:
##########
@@ -32,7 +33,8 @@ public class NettyTransporter implements Transporter {
@Override
public RemotingServer bind(URL url, ChannelHandler handler) throws RemotingException {
- return new NettyServer(url, handler);
+// return new NettyServer(url, handler);
+ return new NettyPortUnificationServer(url, handler);
Review Comment:
Do not replace the original logic. `NettyPortUnificationServer` should be created with `NettyPortUnification Transporter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] TrueAbc closed pull request #10282: abstraction of remoting-api for port unification server
Posted by GitBox <gi...@apache.org>.
TrueAbc closed pull request #10282: abstraction of remoting-api for port unification server
URL: https://github.com/apache/dubbo/pull/10282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] wangchengming666 commented on a diff in pull request #10282: 端口复用remoting层抽象的实现
Posted by GitBox <gi...@apache.org>.
wangchengming666 commented on code in PR #10282:
URL: https://github.com/apache/dubbo/pull/10282#discussion_r915502033
##########
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/api/newportunification/AbstractPortUnificationServer.java:
##########
@@ -0,0 +1,59 @@
+package org.apache.dubbo.remoting.api.newportunification;
+
+import org.apache.dubbo.common.URL;
+import org.apache.dubbo.common.extension.ExtensionLoader;
+import org.apache.dubbo.common.logger.Logger;
+import org.apache.dubbo.common.logger.LoggerFactory;
+import org.apache.dubbo.remoting.ChannelHandler;
+import org.apache.dubbo.remoting.RemotingException;
+import org.apache.dubbo.remoting.transport.AbstractServer;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+
+// 继承了abstract server作为连接管理handler的能力
Review Comment:
hi, please use English to replace comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #10282: abstraction of remoting-api for port unification server
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #10282:
URL: https://github.com/apache/dubbo/pull/10282#issuecomment-1178588264
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/10282?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10282](https://codecov.io/gh/apache/dubbo/pull/10282?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (393b042) into [3.1](https://codecov.io/gh/apache/dubbo/commit/2e5941f87995abea7748d0171b0e6ede3c3e73e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2e5941f) will **decrease** coverage by `0.72%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## 3.1 #10282 +/- ##
============================================
- Coverage 65.55% 64.83% -0.73%
- Complexity 296 319 +23
============================================
Files 1234 1242 +8
Lines 53809 54151 +342
Branches 8120 8131 +11
============================================
- Hits 35277 35108 -169
- Misses 14697 15181 +484
- Partials 3835 3862 +27
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/10282?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...portunification/AbstractPortUnificationServer.java](https://codecov.io/gh/apache/dubbo/pull/10282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvbmV3cG9ydHVuaWZpY2F0aW9uL0Fic3RyYWN0UG9ydFVuaWZpY2F0aW9uU2VydmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ing/api/newportunification/ChannelWithHandler.java](https://codecov.io/gh/apache/dubbo/pull/10282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvbmV3cG9ydHVuaWZpY2F0aW9uL0NoYW5uZWxXaXRoSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ng/api/newportunification/NewProtocolDetector.java](https://codecov.io/gh/apache/dubbo/pull/10282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvbmV3cG9ydHVuaWZpY2F0aW9uL05ld1Byb3RvY29sRGV0ZWN0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...fication/PortUnificationServerHandlerDelegate.java](https://codecov.io/gh/apache/dubbo/pull/10282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9hcGkvbmV3cG9ydHVuaWZpY2F0aW9uL1BvcnRVbmlmaWNhdGlvblNlcnZlckhhbmRsZXJEZWxlZ2F0ZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...g/apache/dubbo/remoting/buffer/ChannelBuffers.java](https://codecov.io/gh/apache/dubbo/pull/10282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9idWZmZXIvQ2hhbm5lbEJ1ZmZlcnMuamF2YQ==) | `75.67% <0.00%> (-9.18%)` | :arrow_down: |
| [...etty4/portunification/NettyChannelWithHandler.java](https://codecov.io/gh/apache/dubbo/pull/10282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L3BvcnR1bmlmaWNhdGlvbi9OZXR0eUNoYW5uZWxXaXRoSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...y4/portunification/NettyPortUnificationServer.java](https://codecov.io/gh/apache/dubbo/pull/10282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L3BvcnR1bmlmaWNhdGlvbi9OZXR0eVBvcnRVbmlmaWNhdGlvblNlcnZlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...unification/NettyPortUnificationServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/10282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L3BvcnR1bmlmaWNhdGlvbi9OZXR0eVBvcnRVbmlmaWNhdGlvblNlcnZlckhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...y4/portunification/PortUnificationTransporter.java](https://codecov.io/gh/apache/dubbo/pull/10282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L3BvcnR1bmlmaWNhdGlvbi9Qb3J0VW5pZmljYXRpb25UcmFuc3BvcnRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...dubbo/remoting/zookeeper/ZookeeperTransporter.java](https://codecov.io/gh/apache/dubbo/pull/10282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy96b29rZWVwZXIvWm9va2VlcGVyVHJhbnNwb3J0ZXIuamF2YQ==) | `55.55% <0.00%> (-33.34%)` | :arrow_down: |
| ... and [67 more](https://codecov.io/gh/apache/dubbo/pull/10282/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/10282?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/10282?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2e5941f...393b042](https://codecov.io/gh/apache/dubbo/pull/10282?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org