You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by GitBox <gi...@apache.org> on 2021/06/23 18:56:05 UTC

[GitHub] [mesos] surahman opened a new pull request #394: [linux] fixed to handle excess tail data in Ubuntu .

surahman opened a new pull request #394:
URL: https://github.com/apache/mesos/pull/394


   **_[MESOS-10244](https://issues.apache.org/jira/browse/MESOS-10224)_**
   
   There is excess data on the tail end of the `ld.cache.so` file on `Ubuntu 21.04`. With this fix the `data` pointer will not fail if it falls short of the end of the cache's buffer end.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mesos] cf-natali commented on pull request #394: [linux] fixed to handle excess tail data in Ubuntu .

Posted by GitBox <gi...@apache.org>.
cf-natali commented on pull request #394:
URL: https://github.com/apache/mesos/pull/394#issuecomment-867184325


   LGTM - @qianzhangxa can you review and merge?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mesos] asfgit closed pull request #394: [linux] fixed to handle excess tail data in Ubuntu .

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #394:
URL: https://github.com/apache/mesos/pull/394


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mesos] surahman commented on pull request #394: [linux] fixed to handle excess tail data in Ubuntu .

Posted by GitBox <gi...@apache.org>.
surahman commented on pull request #394:
URL: https://github.com/apache/mesos/pull/394#issuecomment-867711565


   @cf-natali and @qianzhangxa thank you, I am looking forward to making more substantial contributions going forward.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mesos] qianzhangxa commented on pull request #394: [linux] fixed to handle excess tail data in Ubuntu .

Posted by GitBox <gi...@apache.org>.
qianzhangxa commented on pull request #394:
URL: https://github.com/apache/mesos/pull/394#issuecomment-867602814


   > LGTM - @qianzhangxa can you review and merge?
   
   Sure. Thanks @surahman for your contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mesos] cf-natali commented on a change in pull request #394: [linux] fixed to handle excess tail data in Ubuntu .

Posted by GitBox <gi...@apache.org>.
cf-natali commented on a change in pull request #394:
URL: https://github.com/apache/mesos/pull/394#discussion_r657452395



##########
File path: src/linux/ldcache.cpp
##########
@@ -224,7 +224,7 @@ Try<vector<Entry>> parse(const string& path)
   // contained in the string table. At this point, 'data' should
   // point to an address just beyond the end of the file.

Review comment:
       I think the comment is stale, since `data` won't necessarily point just beyond the end of the file anymore.
   
   Similarly, the comment below will also be stale:
   https://github.com/apache/mesos/blob/15c493c4dba2bf7b5db514e1daefc9c8d4f11bf6/src/linux/ldcache.cpp#L231
   
   ```
     // Make sure the very last character in the buffer is a '\0'.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org