You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Esteve Fernandez (JIRA)" <ji...@apache.org> on 2008/11/20 18:50:44 UTC
[jira] Created: (THRIFT-210) Add support for TFramedTransport
Add support for TFramedTransport
--------------------------------
Key: THRIFT-210
URL: https://issues.apache.org/jira/browse/THRIFT-210
Project: Thrift
Issue Type: New Feature
Components: Library (C#)
Reporter: Esteve Fernandez
The C# library lacks support for framed transports. Here's a patch, but depends on THRIFT-209
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-210) Add support for TFramedTransport
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776200#action_12776200 ]
Esteve Fernandez commented on THRIFT-210:
-----------------------------------------
Michael gave his approval (thanks!), I'll commit his patch in the next hours.
> Add support for TFramedTransport
> --------------------------------
>
> Key: THRIFT-210
> URL: https://issues.apache.org/jira/browse/THRIFT-210
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Attachments: Main.cs, thrift-210.patch, thrift-210_v2.patch, thrift-210_v4.patch
>
>
> The C# library lacks support for framed transports. Here's a patch, but depends on THRIFT-209
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-210) Add support for TFramedTransport
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Esteve Fernandez updated THRIFT-210:
------------------------------------
Attachment: thrift-210.patch
> Add support for TFramedTransport
> --------------------------------
>
> Key: THRIFT-210
> URL: https://issues.apache.org/jira/browse/THRIFT-210
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Attachments: thrift-210.patch
>
>
> The C# library lacks support for framed transports. Here's a patch, but depends on THRIFT-209
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-210) Add support for TFramedTransport
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Esteve Fernandez updated THRIFT-210:
------------------------------------
Attachment: thrift-209.patch
> Add support for TFramedTransport
> --------------------------------
>
> Key: THRIFT-210
> URL: https://issues.apache.org/jira/browse/THRIFT-210
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Attachments: thrift-210.patch
>
>
> The C# library lacks support for framed transports. Here's a patch, but depends on THRIFT-209
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-210) Add support for TFramedTransport
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Esteve Fernandez reassigned THRIFT-210:
---------------------------------------
Assignee: Michael Greene
> Add support for TFramedTransport
> --------------------------------
>
> Key: THRIFT-210
> URL: https://issues.apache.org/jira/browse/THRIFT-210
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Assignee: Michael Greene
> Attachments: Main.cs, thrift-210.patch, thrift-210_v2.patch, thrift-210_v4.patch
>
>
> The C# library lacks support for framed transports. Here's a patch, but depends on THRIFT-209
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-210) Add support for TFramedTransport
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673121#action_12673121 ]
Michael Greene commented on THRIFT-210:
---------------------------------------
* The new file should also be included in Thrift.csproj
* The {{using System.Text;}} statement is unnecessary.
* The code betrays its Java origins a little too much. The rest of our C# code doesn't add encapsulation modifiers to variable names, so I'd prefer to leave the {{_}} off.
I'd like to see some tests if possible. The other transports get exercised in the admittedly simple functional tests.
> Add support for TFramedTransport
> --------------------------------
>
> Key: THRIFT-210
> URL: https://issues.apache.org/jira/browse/THRIFT-210
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Attachments: thrift-210.patch, thrift-210_v2.patch
>
>
> The C# library lacks support for framed transports. Here's a patch, but depends on THRIFT-209
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-210) Add support for TFramedTransport
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672679#action_12672679 ]
Esteve Fernandez commented on THRIFT-210:
-----------------------------------------
Any objections to this? It doesn't cause any side-effects and it's a quite useful feature for the C# users out there.
> Add support for TFramedTransport
> --------------------------------
>
> Key: THRIFT-210
> URL: https://issues.apache.org/jira/browse/THRIFT-210
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Attachments: thrift-210.patch, thrift-210_v2.patch
>
>
> The C# library lacks support for framed transports. Here's a patch, but depends on THRIFT-209
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-210) Add support for TFramedTransport
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728041#action_12728041 ]
Esteve Fernandez commented on THRIFT-210:
-----------------------------------------
I'm not a C# programmer either (I just ported the TFramedTransport from Java), so I'll agree with whatever Michael says :-)
> Add support for TFramedTransport
> --------------------------------
>
> Key: THRIFT-210
> URL: https://issues.apache.org/jira/browse/THRIFT-210
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Attachments: Main.cs, thrift-210.patch, thrift-210_v2.patch, thrift-210_v4.patch
>
>
> The C# library lacks support for framed transports. Here's a patch, but depends on THRIFT-209
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-210) Add support for TFramedTransport
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688478#action_12688478 ]
Bryan Duxbury commented on THRIFT-210:
--------------------------------------
Any chance of this getting completed? Otherwise, we should close the issue.
> Add support for TFramedTransport
> --------------------------------
>
> Key: THRIFT-210
> URL: https://issues.apache.org/jira/browse/THRIFT-210
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Attachments: thrift-210.patch, thrift-210_v2.patch
>
>
> The C# library lacks support for framed transports. Here's a patch, but depends on THRIFT-209
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-210) Add support for TFramedTransport
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725722#action_12725722 ]
Todd Lipcon commented on THRIFT-210:
------------------------------------
I am not a C# programmer, but semantically this looks fine. Adding tests would be good, though.
> Add support for TFramedTransport
> --------------------------------
>
> Key: THRIFT-210
> URL: https://issues.apache.org/jira/browse/THRIFT-210
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Attachments: Main.cs, thrift-210.patch, thrift-210_v2.patch, thrift-210_v4.patch
>
>
> The C# library lacks support for framed transports. Here's a patch, but depends on THRIFT-209
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-210) Add support for TFramedTransport
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Esteve Fernandez resolved THRIFT-210.
-------------------------------------
Resolution: Fixed
> Add support for TFramedTransport
> --------------------------------
>
> Key: THRIFT-210
> URL: https://issues.apache.org/jira/browse/THRIFT-210
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Assignee: Michael Greene
> Attachments: Main.cs, thrift-210.patch, thrift-210_v2.patch, thrift-210_v4.patch
>
>
> The C# library lacks support for framed transports. Here's a patch, but depends on THRIFT-209
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-210) Add support for TFramedTransport
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated THRIFT-210:
----------------------------------
Attachment: Main.cs
thrift-210_v4.patch
Cassandra would like to move to the framed transport (see CASSANDRA-241 ) so I tried this out after making the changes I mentioned above, fixed a glitch with the memory buffer getting prematurely disposed, and added the requisite headers. It works properly with the Cassandra code I'm attaching (Main.cs for reference, not commit).
> Add support for TFramedTransport
> --------------------------------
>
> Key: THRIFT-210
> URL: https://issues.apache.org/jira/browse/THRIFT-210
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Attachments: Main.cs, thrift-210.patch, thrift-210_v2.patch, thrift-210_v4.patch
>
>
> The C# library lacks support for framed transports. Here's a patch, but depends on THRIFT-209
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-210) Add support for TFramedTransport
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Esteve Fernandez updated THRIFT-210:
------------------------------------
Attachment: thrift-210_v2.patch
Removed copyright notice and updated to latest Makefile.am
> Add support for TFramedTransport
> --------------------------------
>
> Key: THRIFT-210
> URL: https://issues.apache.org/jira/browse/THRIFT-210
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Attachments: thrift-210.patch, thrift-210_v2.patch
>
>
> The C# library lacks support for framed transports. Here's a patch, but depends on THRIFT-209
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-210) Add support for TFramedTransport
Posted by "Esteve Fernandez (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Esteve Fernandez updated THRIFT-210:
------------------------------------
Attachment: (was: thrift-209.patch)
> Add support for TFramedTransport
> --------------------------------
>
> Key: THRIFT-210
> URL: https://issues.apache.org/jira/browse/THRIFT-210
> Project: Thrift
> Issue Type: New Feature
> Components: Library (C#)
> Reporter: Esteve Fernandez
> Attachments: thrift-210.patch
>
>
> The C# library lacks support for framed transports. Here's a patch, but depends on THRIFT-209
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.