You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/13 18:58:50 UTC
[GitHub] [incubator-superset] villebro commented on issue #8034: [viz]
Adding get_df typing
villebro commented on issue #8034: [viz] Adding get_df typing
URL: https://github.com/apache/incubator-superset/pull/8034#issuecomment-520964473
I don't feel strongly either way, i.e. returning an empty `DataFrame` or `None`, but I think it's the correct approach to add typing now and make the change later if necessary. Which reminds me that there's a good bit of circular imports going on in `db_engine_specs`and `models/core.py` that showed up when I tried to add typing to `db_engine_specs`. Will try to get around to refactoring that at some point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org