You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Vadim Tsarik (Created) (JIRA)" <ji...@apache.org> on 2011/09/27 17:55:11 UTC
[jira] [Created] (AVRO-898) NettyServer doesn't support SSL
NettyServer doesn't support SSL
-------------------------------
Key: AVRO-898
URL: https://issues.apache.org/jira/browse/AVRO-898
Project: Avro
Issue Type: Bug
Components: java
Affects Versions: 1.5.4
Reporter: Vadim Tsarik
Priority: Critical
While there's a way to configure NettyTransceiver to use SSL by using NettyTransceiver's constructor NettyTransceiver(InetSocketAddress addr, ChannelFactory channelFactory) and providing channelFactory that ensures SslHandler is in the pipeline, there's no way symmetrical capability in NettyServer.
Adding constructor to NettyServer that would take in ChannelFactory could resolve the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-898) NettyServer doesn't support SSL
Posted by "Sebastian Ortega (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebastian Ortega updated AVRO-898:
----------------------------------
Attachment: 0001-Add-NettyServer-constructor-for-custom-pipelines.patch
> NettyServer doesn't support SSL
> -------------------------------
>
> Key: AVRO-898
> URL: https://issues.apache.org/jira/browse/AVRO-898
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.5.4
> Reporter: Vadim Tsarik
> Assignee: Doug Cutting
> Priority: Critical
> Fix For: 1.6.0
>
> Attachments: 0001-Add-NettyServer-constructor-for-custom-pipelines.patch, AVRO-898-suggested-change.patch, AVRO-898.patch
>
>
> While there's a way to configure NettyTransceiver to use SSL by using NettyTransceiver's constructor NettyTransceiver(InetSocketAddress addr, ChannelFactory channelFactory) and providing channelFactory that ensures SslHandler is in the pipeline, there's no symmetrical capability in NettyServer.
> Adding constructor to NettyServer that would take in ChannelFactory could resolve the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-898) NettyServer doesn't support SSL
Posted by "Vadim Tsarik (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vadim Tsarik updated AVRO-898:
------------------------------
Attachment: AVRO-898-suggested-change.patch
Suggested change to fix resolve the issue
> NettyServer doesn't support SSL
> -------------------------------
>
> Key: AVRO-898
> URL: https://issues.apache.org/jira/browse/AVRO-898
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.5.4
> Reporter: Vadim Tsarik
> Priority: Critical
> Attachments: AVRO-898-suggested-change.patch
>
>
> While there's a way to configure NettyTransceiver to use SSL by using NettyTransceiver's constructor NettyTransceiver(InetSocketAddress addr, ChannelFactory channelFactory) and providing channelFactory that ensures SslHandler is in the pipeline, there's no way symmetrical capability in NettyServer.
> Adding constructor to NettyServer that would take in ChannelFactory could resolve the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-898) NettyServer doesn't support SSL
Posted by "Doug Cutting (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-898:
------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I committed this.
> NettyServer doesn't support SSL
> -------------------------------
>
> Key: AVRO-898
> URL: https://issues.apache.org/jira/browse/AVRO-898
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.5.4
> Reporter: Vadim Tsarik
> Assignee: Doug Cutting
> Priority: Critical
> Fix For: 1.6.0
>
> Attachments: AVRO-898-suggested-change.patch, AVRO-898.patch
>
>
> While there's a way to configure NettyTransceiver to use SSL by using NettyTransceiver's constructor NettyTransceiver(InetSocketAddress addr, ChannelFactory channelFactory) and providing channelFactory that ensures SslHandler is in the pipeline, there's no symmetrical capability in NettyServer.
> Adding constructor to NettyServer that would take in ChannelFactory could resolve the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-898) NettyServer doesn't support SSL
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397024#comment-13397024 ]
Doug Cutting commented on AVRO-898:
-----------------------------------
Sebastian,
This issue is closed. If you'd like to propose further changes please open a new issue.
Thanks!
> NettyServer doesn't support SSL
> -------------------------------
>
> Key: AVRO-898
> URL: https://issues.apache.org/jira/browse/AVRO-898
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.5.4
> Reporter: Vadim Tsarik
> Assignee: Doug Cutting
> Priority: Critical
> Fix For: 1.6.0
>
> Attachments: 0001-Add-NettyServer-constructor-for-custom-pipelines.patch, AVRO-898-suggested-change.patch, AVRO-898.patch
>
>
> While there's a way to configure NettyTransceiver to use SSL by using NettyTransceiver's constructor NettyTransceiver(InetSocketAddress addr, ChannelFactory channelFactory) and providing channelFactory that ensures SslHandler is in the pipeline, there's no symmetrical capability in NettyServer.
> Adding constructor to NettyServer that would take in ChannelFactory could resolve the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-898) NettyServer doesn't support SSL
Posted by "Sebastian Ortega (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397313#comment-13397313 ]
Sebastian Ortega commented on AVRO-898:
---------------------------------------
I'll do it right away. Thanks.
> NettyServer doesn't support SSL
> -------------------------------
>
> Key: AVRO-898
> URL: https://issues.apache.org/jira/browse/AVRO-898
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.5.4
> Reporter: Vadim Tsarik
> Assignee: Doug Cutting
> Priority: Critical
> Fix For: 1.6.0
>
> Attachments: 0001-Add-NettyServer-constructor-for-custom-pipelines.patch, AVRO-898-suggested-change.patch, AVRO-898.patch
>
>
> While there's a way to configure NettyTransceiver to use SSL by using NettyTransceiver's constructor NettyTransceiver(InetSocketAddress addr, ChannelFactory channelFactory) and providing channelFactory that ensures SslHandler is in the pipeline, there's no symmetrical capability in NettyServer.
> Adding constructor to NettyServer that would take in ChannelFactory could resolve the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-898) NettyServer doesn't support SSL
Posted by "Doug Cutting (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-898:
------------------------------
Attachment: AVRO-898.patch
Your patch didn't compile. It was missing a closing parenthesis and a 'this.'. I fixed these in the attached patch.
> NettyServer doesn't support SSL
> -------------------------------
>
> Key: AVRO-898
> URL: https://issues.apache.org/jira/browse/AVRO-898
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.5.4
> Reporter: Vadim Tsarik
> Priority: Critical
> Attachments: AVRO-898-suggested-change.patch, AVRO-898.patch
>
>
> While there's a way to configure NettyTransceiver to use SSL by using NettyTransceiver's constructor NettyTransceiver(InetSocketAddress addr, ChannelFactory channelFactory) and providing channelFactory that ensures SslHandler is in the pipeline, there's no symmetrical capability in NettyServer.
> Adding constructor to NettyServer that would take in ChannelFactory could resolve the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-898) NettyServer doesn't support SSL
Posted by "Sebastian Ortega (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396740#comment-13396740 ]
Sebastian Ortega commented on AVRO-898:
---------------------------------------
Hello,
I'm trying to use NettyServer with SSL support and I have problems to do it despite your patch has been accepted. If I am not wrong, the SSLHandler should be added only to the worker pipelines but you cannot tell the difference with the current interface.
I've prepared a patch of a different approach. I've added a new constructor of type ChannelPipelineFactory used to initialize the worker pipeline instead of calling Channels.pipeline() directly. Please see the attached path.
If I'm wrong, I wil be very grateful to know how did you solved it Vadim Tsarik.
Thanks in advance
> NettyServer doesn't support SSL
> -------------------------------
>
> Key: AVRO-898
> URL: https://issues.apache.org/jira/browse/AVRO-898
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.5.4
> Reporter: Vadim Tsarik
> Assignee: Doug Cutting
> Priority: Critical
> Fix For: 1.6.0
>
> Attachments: 0001-Add-NettyServer-constructor-for-custom-pipelines.patch, AVRO-898-suggested-change.patch, AVRO-898.patch
>
>
> While there's a way to configure NettyTransceiver to use SSL by using NettyTransceiver's constructor NettyTransceiver(InetSocketAddress addr, ChannelFactory channelFactory) and providing channelFactory that ensures SslHandler is in the pipeline, there's no symmetrical capability in NettyServer.
> Adding constructor to NettyServer that would take in ChannelFactory could resolve the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-898) NettyServer doesn't support SSL
Posted by "Vadim Tsarik (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vadim Tsarik updated AVRO-898:
------------------------------
Description:
While there's a way to configure NettyTransceiver to use SSL by using NettyTransceiver's constructor NettyTransceiver(InetSocketAddress addr, ChannelFactory channelFactory) and providing channelFactory that ensures SslHandler is in the pipeline, there's no symmetrical capability in NettyServer.
Adding constructor to NettyServer that would take in ChannelFactory could resolve the issue.
was:
While there's a way to configure NettyTransceiver to use SSL by using NettyTransceiver's constructor NettyTransceiver(InetSocketAddress addr, ChannelFactory channelFactory) and providing channelFactory that ensures SslHandler is in the pipeline, there's no way symmetrical capability in NettyServer.
Adding constructor to NettyServer that would take in ChannelFactory could resolve the issue.
> NettyServer doesn't support SSL
> -------------------------------
>
> Key: AVRO-898
> URL: https://issues.apache.org/jira/browse/AVRO-898
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.5.4
> Reporter: Vadim Tsarik
> Priority: Critical
> Attachments: AVRO-898-suggested-change.patch
>
>
> While there's a way to configure NettyTransceiver to use SSL by using NettyTransceiver's constructor NettyTransceiver(InetSocketAddress addr, ChannelFactory channelFactory) and providing channelFactory that ensures SslHandler is in the pipeline, there's no symmetrical capability in NettyServer.
> Adding constructor to NettyServer that would take in ChannelFactory could resolve the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-898) NettyServer doesn't support SSL
Posted by "Doug Cutting (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-898:
------------------------------
Fix Version/s: 1.6.0
Assignee: Doug Cutting
Status: Patch Available (was: Open)
This looks like a reasonable change to me. I'll commit it in the next few days unless someone objects.
> NettyServer doesn't support SSL
> -------------------------------
>
> Key: AVRO-898
> URL: https://issues.apache.org/jira/browse/AVRO-898
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.5.4
> Reporter: Vadim Tsarik
> Assignee: Doug Cutting
> Priority: Critical
> Fix For: 1.6.0
>
> Attachments: AVRO-898-suggested-change.patch, AVRO-898.patch
>
>
> While there's a way to configure NettyTransceiver to use SSL by using NettyTransceiver's constructor NettyTransceiver(InetSocketAddress addr, ChannelFactory channelFactory) and providing channelFactory that ensures SslHandler is in the pipeline, there's no symmetrical capability in NettyServer.
> Adding constructor to NettyServer that would take in ChannelFactory could resolve the issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira