[jira] [Commented] (HBASE-12912) StoreScanner calls Configuration for Boolean Check on each initialization

["Enis Soztutar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-12912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390147#comment-14390147 ] 

Enis Soztutar commented on HBASE-12912:
---------------------------------------

We do not need to remove the configs I think. We can do a StoreScannerConfig object, and construct it once by passing the conf from Store. Then the StoreScanners are constructed with that the Config object which contains the parsed configs (see TableConfiguration as an example). 

> StoreScanner calls Configuration for Boolean Check on each initialization
> -------------------------------------------------------------------------
>
>                 Key: HBASE-12912
>                 URL: https://issues.apache.org/jira/browse/HBASE-12912
>             Project: HBase
>          Issue Type: Bug
>            Reporter: John Leach
>            Assignee: John Leach
>             Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13
>
>         Attachments: StoreScannerStall.tiff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> There is a clear CPU drain and iterator creation when creating store scanners under high load.  Splice was running a TPCC test of our database and we are seeing object creation and CPU waste on the boolean check....
> Code Snippet...
> if (store != null && ((HStore)store).getHRegion() != null
>         && store.getStorefilesCount() > 1) {
>       RegionServerServices rsService = ((HStore)store).getHRegion().getRegionServerServices();
>       if (rsService == null || !rsService.getConfiguration().getBoolean(
>             STORESCANNER_PARALLEL_SEEK_ENABLE, false)) return;
>       isParallelSeekEnabled = true;
>       executor = rsService.getExecutorService();
>     }
> Will attach profile...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)