You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/09/01 09:38:52 UTC
[GitHub] [beam] tvalentyn commented on a change in pull request #15308: [BEAM-11167] Updates dill package
tvalentyn commented on a change in pull request #15308:
URL: https://github.com/apache/beam/pull/15308#discussion_r699560716
##########
File path: sdks/python/setup.py
##########
@@ -139,7 +139,7 @@ def get_version():
# version of dill. It is best to use the same version of dill on client and
# server, therefore list of allowed versions is very narrow.
# See: https://github.com/uqfoundation/dill/issues/341.
- 'dill>=0.3.1.1,<0.3.2',
+ 'dill>=0.3.1.1,<0.3.4',
Review comment:
we need to keep a very tight upper + lower bound dill, see: https://lists.apache.org/thread.html/r90940a6953f546f4839ade82dfad2e494c4273a1931505ddebcb7627%40%3Cdev.beam.apache.org%3E
##########
File path: sdks/python/setup.py
##########
@@ -139,7 +139,7 @@ def get_version():
# version of dill. It is best to use the same version of dill on client and
# server, therefore list of allowed versions is very narrow.
# See: https://github.com/uqfoundation/dill/issues/341.
- 'dill>=0.3.1.1,<0.3.2',
+ 'dill>=0.3.1.1,<0.3.4',
Review comment:
so you'd have to write
>=0.3.4,<0.3.5
##########
File path: sdks/python/setup.py
##########
@@ -139,7 +139,7 @@ def get_version():
# version of dill. It is best to use the same version of dill on client and
# server, therefore list of allowed versions is very narrow.
# See: https://github.com/uqfoundation/dill/issues/341.
- 'dill>=0.3.1.1,<0.3.2',
+ 'dill>=0.3.1.1,<0.3.4',
Review comment:
so you'd have to write
`>=0.3.4,<0.3.5`
##########
File path: sdks/python/setup.py
##########
@@ -139,7 +139,7 @@ def get_version():
# version of dill. It is best to use the same version of dill on client and
# server, therefore list of allowed versions is very narrow.
# See: https://github.com/uqfoundation/dill/issues/341.
- 'dill>=0.3.1.1,<0.3.2',
+ 'dill>=0.3.1.1,<0.3.4',
Review comment:
most likely this is what is causing test failures.
##########
File path: sdks/python/setup.py
##########
@@ -139,7 +139,7 @@ def get_version():
# version of dill. It is best to use the same version of dill on client and
# server, therefore list of allowed versions is very narrow.
# See: https://github.com/uqfoundation/dill/issues/341.
- 'dill>=0.3.1.1,<0.3.2',
+ 'dill>=0.3.1.1,<0.3.4',
Review comment:
most likely this is what is causing test failures on this PR
##########
File path: sdks/python/setup.py
##########
@@ -139,7 +139,7 @@ def get_version():
# version of dill. It is best to use the same version of dill on client and
# server, therefore list of allowed versions is very narrow.
# See: https://github.com/uqfoundation/dill/issues/341.
- 'dill>=0.3.1.1,<0.3.2',
+ 'dill>=0.3.1.1,<0.3.4',
Review comment:
Also minor correction to note: the current bound <0.3.4 does not include 3.4
##########
File path: sdks/python/setup.py
##########
@@ -139,7 +139,7 @@ def get_version():
# version of dill. It is best to use the same version of dill on client and
# server, therefore list of allowed versions is very narrow.
# See: https://github.com/uqfoundation/dill/issues/341.
- 'dill>=0.3.1.1,<0.3.2',
+ 'dill>=0.3.1.1,<0.3.4',
Review comment:
thanks a lot for looking into these changes though, dill is a tricky dependency to deal with...
##########
File path: sdks/python/setup.py
##########
@@ -139,7 +139,7 @@ def get_version():
# version of dill. It is best to use the same version of dill on client and
# server, therefore list of allowed versions is very narrow.
# See: https://github.com/uqfoundation/dill/issues/341.
- 'dill>=0.3.1.1,<0.3.2',
+ 'dill>=0.3.1.1,<0.3.4',
Review comment:
cc: @ryanthompson591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org