You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/03/14 08:54:23 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #5144: Refactor
value based segment pruner to work on DataSource instead of ColumnMetadata
codecov-io commented on issue #5144: Refactor value based segment pruner to work on DataSource instead of ColumnMetadata
URL: https://github.com/apache/incubator-pinot/pull/5144#issuecomment-599030074
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5144?src=pr&el=h1) Report
> Merging [#5144](https://codecov.io/gh/apache/incubator-pinot/pull/5144?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/d989427ec076d4553206e9fdd062be24de50477d&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `89.21%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5144?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5144 +/- ##
============================================
- Coverage 66.10% 66.07% -0.04%
Complexity 12 12
============================================
Files 1052 1050 -2
Lines 54151 54113 -38
Branches 8081 8071 -10
============================================
- Hits 35796 35754 -42
- Misses 15690 15706 +16
+ Partials 2665 2653 -12
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5144?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pinot/core/query/pruner/SegmentPrunerProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/5144/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9wcnVuZXIvU2VnbWVudFBydW5lclByb3ZpZGVyLmphdmE=) | `56.25% <ø> (-2.58%)` | `0.00 <0.00> (ø)` | |
| [...starter/helix/DefaultHelixStarterServerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5144/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9EZWZhdWx0SGVsaXhTdGFydGVyU2VydmVyQ29uZmlnLmphdmE=) | `95.83% <ø> (-0.60%)` | `0.00 <0.00> (ø)` | |
| [...ot/core/query/pruner/ColumnValueSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/5144/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9wcnVuZXIvQ29sdW1uVmFsdWVTZWdtZW50UHJ1bmVyLmphdmE=) | `88.42% <87.77%> (+2.11%)` | `0.00 <0.00> (ø)` | |
| [...e/pinot/core/query/config/SegmentPrunerConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5144/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9jb25maWcvU2VnbWVudFBydW5lckNvbmZpZy5qYXZh) | `100.00% <100.00%> (+15.78%)` | `0.00 <0.00> (ø)` | |
| [.../pinot/core/query/pruner/SegmentPrunerService.java](https://codecov.io/gh/apache/incubator-pinot/pull/5144/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9wcnVuZXIvU2VnbWVudFBydW5lclNlcnZpY2UuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...core/query/exception/BadQueryRequestException.java](https://codecov.io/gh/apache/incubator-pinot/pull/5144/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9leGNlcHRpb24vQmFkUXVlcnlSZXF1ZXN0RXhjZXB0aW9uLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `0.00% <0.00%> (ø%)` | |
| [...elix/core/relocation/RealtimeSegmentRelocator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5144/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlbG9jYXRpb24vUmVhbHRpbWVTZWdtZW50UmVsb2NhdG9yLmphdmE=) | `23.68% <0.00%> (-21.06%)` | `0.00% <0.00%> (ø%)` | |
| [...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5144/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `57.31% <0.00%> (-19.52%)` | `0.00% <0.00%> (ø%)` | |
| [...impl/dictionary/FloatOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/5144/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPZmZIZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `59.13% <0.00%> (-8.61%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/pinot/broker/queryquota/HitCounter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5144/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9IaXRDb3VudGVyLmphdmE=) | `92.30% <0.00%> (-7.70%)` | `0.00% <0.00%> (ø%)` | |
| ... and [26 more](https://codecov.io/gh/apache/incubator-pinot/pull/5144/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5144?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5144?src=pr&el=footer). Last update [d989427...9162a48](https://codecov.io/gh/apache/incubator-pinot/pull/5144?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org