You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/03/19 14:57:32 UTC
[GitHub] [systemds] OlgaOvcharenko opened a new pull request #1207: [WIP][SYSTEMDS-2905] Add MetaAll
OlgaOvcharenko opened a new pull request #1207:
URL: https://github.com/apache/systemds/pull/1207
This PR adds new MetaAll class instead of parse, read of JSON in DataExpression to clean it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard commented on a change in pull request #1207: [SYSTEMDS-2905] Add MetaAll
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on a change in pull request #1207:
URL: https://github.com/apache/systemds/pull/1207#discussion_r613136603
##########
File path: src/test/scripts/functions/io/csv/csv_verify2.R
##########
@@ -26,7 +26,8 @@ options(digits=22)
library(Matrix);
-A = read.csv(args[1]);
+A = read.csv(args[1], header=TRUE, sep=",");
Review comment:
should not be modified
##########
File path: src/test/scripts/functions/io/csv/ReadCSVTest_2.dml
##########
@@ -20,8 +20,7 @@
#-------------------------------------------------------------
# DML script that tests read csv
-
-A = read($1, format="csv", header=TRUE);
+A = read($1, format="csv", header=TRUE, sep=",");
Review comment:
should not be modified
##########
File path: src/main/java/org/apache/sysds/runtime/io/ReaderTextCSVParallel.java
##########
@@ -121,8 +122,9 @@ private void readCSVMatrixFromHDFS(InputSplit[] splits, Path path, MatrixBlock d
FileInputFormat.addInputPath(_job, path);
TextInputFormat informat = new TextInputFormat();
- informat.configure(_job);
+ informat.configure(_job);
+
Review comment:
should not be modified
##########
File path: src/main/java/org/apache/sysds/runtime/io/ReaderTextCellParallel.java
##########
@@ -256,7 +256,7 @@ public Void call() throws Exception {
LongWritable key = new LongWritable();
Text value = new Text();
FastStringTokenizer st = new FastStringTokenizer(' ');
-
+
Review comment:
should not be modified
##########
File path: src/main/java/org/apache/sysds/runtime/io/ReaderTextCSV.java
##########
@@ -58,13 +59,13 @@ public MatrixBlock readMatrixFromHDFS(String fname, long rlen, long clen, int bl
ret = createOutputMatrixBlock(rlen, clen, (int)rlen, estnnz, true, false);
//prepare file access
- JobConf job = new JobConf(ConfigurationManager.getCachedJobConf());
+ JobConf job = new JobConf(ConfigurationManager.getCachedJobConf());
Path path = new Path( fname );
FileSystem fs = IOUtilFunctions.getFileSystem(path, job);
//check existence and non-empty file
- checkValidInputFile(fs, path);
-
+ checkValidInputFile(fs, path);
+
Review comment:
should not be modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard closed pull request #1207: [SYSTEMDS-2905] Add MetaAll
Posted by GitBox <gi...@apache.org>.
Baunsgaard closed pull request #1207:
URL: https://github.com/apache/systemds/pull/1207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org