You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2024/05/02 01:02:27 UTC

[I] Implement Spark-compatible CAST from floating-point to decimal [datafusion-comet]

andygrove opened a new issue, #371:
URL: https://github.com/apache/datafusion-comet/issues/371

   ### What is the problem the feature request solves?
   
   Comet's implementation of CAST float/double to Decimal delegates to DataFusion and is not compatible with Spark.
   
   The following test in `CometCastSuite` can be used to see the current failures.
   
   ```scala
     ignore("cast DoubleType to DecimalType(10,2)") {
       // Comet should have failed with [NUMERIC_VALUE_OUT_OF_RANGE]
       castTest(generateDoubles(), DataTypes.createDecimalType(10, 2))
     }
   ```
   
   ### Describe the potential solution
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Implement Spark-compatible CAST from floating-point to decimal [datafusion-comet]

Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove closed issue #371: Implement Spark-compatible CAST from floating-point to decimal
URL: https://github.com/apache/datafusion-comet/issues/371


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [I] Implement Spark-compatible CAST from floating-point to decimal [datafusion-comet]

Posted by "vaibhawvipul (via GitHub)" <gi...@apache.org>.
vaibhawvipul commented on issue #371:
URL: https://github.com/apache/datafusion-comet/issues/371#issuecomment-2091226397

   I would like to work on this. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org