You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/11 14:04:54 UTC

[GitHub] [skywalking-python] tom-pytel opened a new pull request #99: Fix: queue.get(block=False) can raise Empty

tom-pytel opened a new pull request #99:
URL: https://github.com/apache/skywalking-python/pull/99


   Minor fix for previous PR, calling `queue.get(block=False)` can raise `_queue.Empty` which would print out an exception on exit.
   
   <!-- Uncomment the following checklist WHEN AND ONLY WHEN you're adding a new plugin -->
   <!--
   - [ ] Add a test case for the new plugin
   - [ ] Add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L415)
   - [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
   - [ ] Rebuild the `requirements.txt` by running `tools/env/build_requirements_(linux|windows).sh`
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-python] kezhenxu94 merged pull request #99: Fix: queue.get(block=False) can raise Empty

Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #99:
URL: https://github.com/apache/skywalking-python/pull/99


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org