You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemml.apache.org by GitBox <gi...@apache.org> on 2020/06/01 20:41:39 UTC
[GitHub] [systemml] mboehm7 commented on a change in pull request #909: [SYSTEMDS-???] [WIP] Distinct values estimation function
mboehm7 commented on a change in pull request #909:
URL: https://github.com/apache/systemml/pull/909#discussion_r433477554
##########
File path: src/main/java/org/apache/sysds/lops/PartialAggregate.java
##########
@@ -340,6 +338,17 @@ else if( dir == Direction.Col )
return "uaktrace";
break;
}
+
+ case COUNT_DISTINCT: {
+ if(dir == Direction.RowCol )
+ return "countDistinct";
+ break;
+ }
+ case COUNT_DISTINCT_ESTIMATE_KMV: {
+ if(dir == Direction.RowCol )
+ return "countDistinctEstimateKMV";
Review comment:
sounds good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org