You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by GitBox <gi...@apache.org> on 2021/04/09 07:15:45 UTC

[GitHub] [shiro] bmarwell edited a comment on pull request #286: [SHIRO-812] Key value separator in config is broken with escape char

bmarwell edited a comment on pull request #286:
URL: https://github.com/apache/shiro/pull/286#issuecomment-798887811


   > I have one test failed but do we want this to be possible?
   > 
   > ```
   >     @Test
   >     public void testSplitKeyValueEscapedEquals()  {
   >         String test = "Truth\\=Beauty";
   >         String[] kv = Ini.Section.splitKeyValue(test);
   >         assertEquals("Truth", kv[0]);
   >         assertEquals("Beauty", kv[1]);
   >     }
   > ```
   
   For 2.0: no, we do not want to retain such irrational behaviour. For me, the equals sign is escaped.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org